From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01E11C5519F for ; Sun, 15 Nov 2020 00:25:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADD872415A for ; Sun, 15 Nov 2020 00:25:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nbz5Es69" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726460AbgKOAZV (ORCPT ); Sat, 14 Nov 2020 19:25:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:38854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgKOAZV (ORCPT ); Sat, 14 Nov 2020 19:25:21 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (c-67-180-217-166.hsd1.ca.comcast.net [67.180.217.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E646F24073; Sun, 15 Nov 2020 00:25:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605399921; bh=4YtwiFMAKU7O5n0zitIAD2AbBo6E1Z6S8SKrGFCC5Bg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Nbz5Es695NhLdX1qEW+EPh+JZZcnRgTajh+Nfkq3uZrbT9eOi9JoloKp3fxl8emS6 B0vrCvFr1QMsZ8ZFYbNQvB//LT+SsaU6zAzgCIm14rVkpgnrtYE3QQsjl+0IUFodMj aimQh1AJ1TrPKLhzwkVzeP6LTO50kQlX0ReIhflc= Date: Sat, 14 Nov 2020 16:25:20 -0800 From: Jakub Kicinski To: Wang Hai Cc: , , , , Subject: Re: [PATCH v2 net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill() Message-ID: <20201114162520.594e58b7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201113111622.11040-1-wanghai38@huawei.com> References: <20201113111622.11040-1-wanghai38@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Nov 2020 19:16:22 +0800 Wang Hai wrote: > If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), > msg should be canceled by genlmsg_cancel(). > > Fixes: df38dafd2559 ("devlink: implement shared buffer occupancy monitoring interface") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Applied, thanks!