From: Jiri Olsa <jolsa@redhat.com>
To: James Clark <james.clark@arm.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Richter <tmricht@linux.ibm.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH 04/13 v4] perf tools: Replace aggregation ID with a struct
Date: Sun, 15 Nov 2020 22:17:53 +0100 [thread overview]
Message-ID: <20201115211753.GD1081385@krava> (raw)
In-Reply-To: <20201113172654.989-5-james.clark@arm.com>
On Fri, Nov 13, 2020 at 07:26:45PM +0200, James Clark wrote:
SNIP
> @@ -754,7 +766,7 @@ static void print_aggr_thread(struct perf_stat_config *config,
> FILE *output = config->output;
> int nthreads = perf_thread_map__nr(counter->core.threads);
> int ncpus = perf_cpu_map__nr(counter->core.cpus);
> - int thread, sorted_threads, id;
> + int thread, sorted_threads;
> struct perf_aggr_thread_value *buf;
>
> buf = sort_aggr_thread(counter, nthreads, ncpus, &sorted_threads, _target);
> @@ -767,13 +779,12 @@ static void print_aggr_thread(struct perf_stat_config *config,
> if (prefix)
> fprintf(output, "%s", prefix);
>
> - id = buf[thread].id;
would it be less changes in here if you kept id with new type?
jirka
> if (config->stats)
> - printout(config, id, 0, buf[thread].counter, buf[thread].uval,
> + printout(config, buf[thread].id, 0, buf[thread].counter, buf[thread].uval,
> prefix, buf[thread].run, buf[thread].ena, 1.0,
> - &config->stats[id]);
> + &config->stats[buf[thread].id.id]);
> else
> - printout(config, id, 0, buf[thread].counter, buf[thread].uval,
> + printout(config, buf[thread].id, 0, buf[thread].counter, buf[thread].uval,
> prefix, buf[thread].run, buf[thread].ena, 1.0,
> &rt_stat);
> fputc('\n', output);
SNIP
next prev parent reply other threads:[~2020-11-15 21:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 17:26 [PATCH 00/13 v4] perf tools: fix perf stat with large socket IDs James Clark
2020-11-13 17:26 ` [PATCH 01/13 v4] perf tools: Improve topology test James Clark
2020-11-13 17:26 ` [PATCH 02/13 v4] perf tools: Use allocator for perf_cpu_map James Clark
2020-11-15 21:17 ` Jiri Olsa
2020-11-17 14:50 ` James Clark
2020-11-13 17:26 ` [PATCH 03/13 v4] perf tools: Add new struct for cpu aggregation James Clark
2020-11-13 17:26 ` [PATCH 04/13 v4] perf tools: Replace aggregation ID with a struct James Clark
2020-11-15 21:17 ` Jiri Olsa [this message]
2020-11-17 14:51 ` James Clark
2020-11-13 17:26 ` [PATCH 05/13 v4] perf tools: add new map type for aggregation James Clark
2020-11-13 17:26 ` [PATCH 06/13 v4] perf tools: drop in cpu_aggr_map struct James Clark
2020-11-13 17:26 ` [PATCH 07/13 v4] perf tools: restrict visibility of functions James Clark
2020-11-15 21:17 ` Jiri Olsa
2020-11-17 14:52 ` James Clark
2020-11-13 17:26 ` [PATCH 08/13 v4] perf tools: Start using cpu_aggr_id in map James Clark
2020-11-13 17:26 ` [PATCH 09/13 v4] perf tools: Add separate node member James Clark
2020-11-13 17:26 ` [PATCH 10/13 v4] perf tools: Add separate socket member James Clark
2020-11-13 17:26 ` [PATCH 11/13 v4] perf tools: Add separate die member James Clark
2020-11-13 17:26 ` [PATCH 12/13 v4] perf tools: Add separate core member James Clark
2020-11-13 17:26 ` [PATCH 13/13 v4] perf tools: add thread field James Clark
2020-11-15 21:17 ` Jiri Olsa
2020-11-17 14:53 ` James Clark
2020-11-15 21:18 ` [PATCH 00/13 v4] perf tools: fix perf stat with large socket IDs Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201115211753.GD1081385@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tmricht@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).