From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C9B2C61DD8 for ; Mon, 16 Nov 2020 16:29:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06B7D21527 for ; Mon, 16 Nov 2020 16:29:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TkwDO8qI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732125AbgKPQ27 (ORCPT ); Mon, 16 Nov 2020 11:28:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730795AbgKPQ27 (ORCPT ); Mon, 16 Nov 2020 11:28:59 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D966CC0613CF; Mon, 16 Nov 2020 08:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=e6BIfEgLkkUxsF4JnpPb8DQA1qDtb10rWlavNgMcshc=; b=TkwDO8qI70+8k28fwxwWYA22+F oyOJIZthD5i8Uiq5L/C85fjaQ4tukb00LfGvBmcAXcG9RfCXGguc3eUTXTKn8SlLGxAfoKXnP1FsB 08H/JpHSTfRTfjg3knsT+dV7hws49LNcp2145KJM6C9fBxaTytcj9KzZIjUgFio8RhHcSf5ZPuzgf +VjTYMxfzdzZnUVfuWVgS+qSG16pktxVQm1re3xtPqHxIHZvX6j41u80C4EjY/PDhon+DdpmVb3cP wI292BEj9Fegqi6XCXXT1PJ9/SpS8vy7ldK4JrXTqrfIcwp5iAeBk/GrgxxFz6F3mdOuHV3fgb5Jc X8CdcWsA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kehMy-0004U3-Jx; Mon, 16 Nov 2020 16:28:44 +0000 Date: Mon, 16 Nov 2020 16:28:44 +0000 From: Christoph Hellwig To: Arnaud POULIQUEN Cc: Christoph Hellwig , Alexander Lobakin , Amit Shah , Arnd Bergmann , Greg Kroah-Hartman , Suman Anna , Mathieu Poirier , Bjorn Andersson , Ohad Ben-Cohen , "Michael S. Tsirkin" , Jason Wang , "virtualization@lists.linux-foundation.org" , "linux-remoteproc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH virtio] virtio: virtio_console: fix DMA memory allocation for rproc serial Message-ID: <20201116162844.GB16619@infradead.org> References: <20201116091950.GA30524@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 16, 2020 at 11:46:59AM +0100, Arnaud POULIQUEN wrote: > Hi all, > > On 11/16/20 10:19 AM, Christoph Hellwig wrote: > > I just noticed this showing up in Linus' tree and I'm not happy. > > > > This whole model of the DMA subdevices in remoteproc is simply broken. > > > > We really need to change the virtio code pass an expicit DMA device ( > > similar to what e.g. the USB and RDMA code does), instead of faking up > > devices with broken adhoc inheritance of DMA properties and magic poking > > into device parent relationships. > > For your formation I started some stuff on my side to be able to declare the > virtio device in DT as a remoteproc child node. > > https://lkml.org/lkml/2020/4/16/1817 > > Quite big refactoring, but could be a way to answer... Yes, that series is exactly what we need to do conceptually (can't comment on all the nitty grity details as I'm not too familiar with the remoteproc code).