linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests
@ 2020-11-16 17:53 ` Krzysztof Kozlowski
  2020-11-16 17:53   ` [PATCH 2/2] drm/ingenic: " Krzysztof Kozlowski
  2020-11-23  1:24   ` [PATCH 1/2] drm/exynos: " Inki Dae
  0 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-16 17:53 UTC (permalink / raw)
  To: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	David Airlie, Daniel Vetter, Krzysztof Kozlowski, Paul Cercueil,
	dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel
  Cc: kernel test robot

The Exynos DRM uses Common Clock Framework thus it cannot be built on
platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):

    /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/exynos/exynos_mixer.o: in function `mixer_bind':
    exynos_mixer.c:(.text+0x958): undefined reference to `clk_set_parent'

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/gpu/drm/exynos/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
index 6417f374b923..951d5f708e92 100644
--- a/drivers/gpu/drm/exynos/Kconfig
+++ b/drivers/gpu/drm/exynos/Kconfig
@@ -1,7 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0-only
 config DRM_EXYNOS
 	tristate "DRM Support for Samsung SoC Exynos Series"
-	depends on OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST)
+	depends on OF && DRM && COMMON_CLK
+	depends on ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST
 	depends on MMU
 	select DRM_KMS_HELPER
 	select VIDEOMODE_HELPERS
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests
  2020-11-16 17:53 ` [PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
@ 2020-11-16 17:53   ` Krzysztof Kozlowski
  2020-11-16 19:54     ` Paul Cercueil
  2020-11-23  1:24   ` [PATCH 1/2] drm/exynos: " Inki Dae
  1 sibling, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-11-16 17:53 UTC (permalink / raw)
  To: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	David Airlie, Daniel Vetter, Krzysztof Kozlowski, Paul Cercueil,
	dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel
  Cc: kernel test robot

The Ingenic DRM uses Common Clock Framework thus it cannot be built on
platforms without it (e.g. compile test on MIPS with RALINK and
SOC_RT305X):

    /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function `ingenic_drm_bind.isra.0':
    ingenic-drm-drv.c:(.text+0x1600): undefined reference to `clk_get_parent'
    /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0): undefined reference to `clk_get_parent'

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/gpu/drm/ingenic/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig
index 477d5387e43e..3b57f8be007c 100644
--- a/drivers/gpu/drm/ingenic/Kconfig
+++ b/drivers/gpu/drm/ingenic/Kconfig
@@ -4,6 +4,7 @@ config DRM_INGENIC
 	depends on DRM
 	depends on CMA
 	depends on OF
+	depends on COMMON_CLK
 	select DRM_BRIDGE
 	select DRM_PANEL_BRIDGE
 	select DRM_KMS_HELPER
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests
  2020-11-16 17:53   ` [PATCH 2/2] drm/ingenic: " Krzysztof Kozlowski
@ 2020-11-16 19:54     ` Paul Cercueil
  2020-12-04  8:18       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Cercueil @ 2020-11-16 19:54 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	David Airlie, Daniel Vetter, dri-devel, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, kernel test robot

Hi Krzysztof,

Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski <krzk@kernel.org> a 
écrit :
> The Ingenic DRM uses Common Clock Framework thus it cannot be built on
> platforms without it (e.g. compile test on MIPS with RALINK and
> SOC_RT305X):
> 
>     /usr/bin/mips-linux-gnu-ld: 
> drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function 
> `ingenic_drm_bind.isra.0':
>     ingenic-drm-drv.c:(.text+0x1600): undefined reference to 
> `clk_get_parent'
>     /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0): 
> undefined reference to `clk_get_parent'
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  drivers/gpu/drm/ingenic/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/ingenic/Kconfig 
> b/drivers/gpu/drm/ingenic/Kconfig
> index 477d5387e43e..3b57f8be007c 100644
> --- a/drivers/gpu/drm/ingenic/Kconfig
> +++ b/drivers/gpu/drm/ingenic/Kconfig
> @@ -4,6 +4,7 @@ config DRM_INGENIC
>  	depends on DRM
>  	depends on CMA
>  	depends on OF
> +	depends on COMMON_CLK
>  	select DRM_BRIDGE
>  	select DRM_PANEL_BRIDGE
>  	select DRM_KMS_HELPER
> --
> 2.25.1
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests
  2020-11-16 17:53 ` [PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
  2020-11-16 17:53   ` [PATCH 2/2] drm/ingenic: " Krzysztof Kozlowski
@ 2020-11-23  1:24   ` Inki Dae
  1 sibling, 0 replies; 6+ messages in thread
From: Inki Dae @ 2020-11-23  1:24 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Joonyoung Shim, Seung-Woo Kim,
	Kyungmin Park, David Airlie, Daniel Vetter, Paul Cercueil,
	dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel
  Cc: kernel test robot

HI Krzysztof,

20. 11. 17. 오전 2:53에 Krzysztof Kozlowski 이(가) 쓴 글:
> The Exynos DRM uses Common Clock Framework thus it cannot be built on
> platforms without it (e.g. compile test on MIPS with RALINK and
> SOC_RT305X):
> 
>     /usr/bin/mips-linux-gnu-ld: drivers/gpu/drm/exynos/exynos_mixer.o: in function `mixer_bind':
>     exynos_mixer.c:(.text+0x958): undefined reference to `clk_set_parent'
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

Picked it up.

Thanks,
Inki Dae

> ---
>  drivers/gpu/drm/exynos/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig
> index 6417f374b923..951d5f708e92 100644
> --- a/drivers/gpu/drm/exynos/Kconfig
> +++ b/drivers/gpu/drm/exynos/Kconfig
> @@ -1,7 +1,8 @@
>  # SPDX-License-Identifier: GPL-2.0-only
>  config DRM_EXYNOS
>  	tristate "DRM Support for Samsung SoC Exynos Series"
> -	depends on OF && DRM && (ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST)
> +	depends on OF && DRM && COMMON_CLK
> +	depends on ARCH_S3C64XX || ARCH_S5PV210 || ARCH_EXYNOS || ARCH_MULTIPLATFORM || COMPILE_TEST
>  	depends on MMU
>  	select DRM_KMS_HELPER
>  	select VIDEOMODE_HELPERS
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile tests
  2020-11-16 19:54     ` Paul Cercueil
@ 2020-12-04  8:18       ` Krzysztof Kozlowski
  2020-12-04 10:07         ` Paul Cercueil
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-12-04  8:18 UTC (permalink / raw)
  To: Paul Cercueil, David Airlie, Daniel Vetter
  Cc: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Kyungmin Park,
	dri-devel, linux-arm-kernel, linux-samsung-soc, linux-kernel,
	kernel test robot

On Mon, Nov 16, 2020 at 07:54:03PM +0000, Paul Cercueil wrote:
> Hi Krzysztof,
> 
> Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski <krzk@kernel.org> a écrit
> :
> > The Ingenic DRM uses Common Clock Framework thus it cannot be built on
> > platforms without it (e.g. compile test on MIPS with RALINK and
> > SOC_RT305X):
> > 
> >     /usr/bin/mips-linux-gnu-ld:
> > drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function
> > `ingenic_drm_bind.isra.0':
> >     ingenic-drm-drv.c:(.text+0x1600): undefined reference to
> > `clk_get_parent'
> >     /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0):
> > undefined reference to `clk_get_parent'
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> Acked-by: Paul Cercueil <paul@crapouillou.net>

Thanks for the ack.

David and Daniel,
I think there is no dedicated maintainer for Ingenic DRM, so can you
pick it up directly?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] drm/ingenic: depend on COMMON_CLK to fix compile  tests
  2020-12-04  8:18       ` Krzysztof Kozlowski
@ 2020-12-04 10:07         ` Paul Cercueil
  0 siblings, 0 replies; 6+ messages in thread
From: Paul Cercueil @ 2020-12-04 10:07 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: David Airlie, Daniel Vetter, Inki Dae, Joonyoung Shim,
	Seung-Woo Kim, Kyungmin Park, dri-devel, linux-arm-kernel,
	linux-samsung-soc, linux-kernel, kernel test robot

Hi Krzysztof,

Le ven. 4 déc. 2020 à 10:18, Krzysztof Kozlowski <krzk@kernel.org> a 
écrit :
> On Mon, Nov 16, 2020 at 07:54:03PM +0000, Paul Cercueil wrote:
>>  Hi Krzysztof,
>> 
>>  Le lun. 16 nov. 2020 à 18:53, Krzysztof Kozlowski 
>> <krzk@kernel.org> a écrit
>>  :
>>  > The Ingenic DRM uses Common Clock Framework thus it cannot be 
>> built on
>>  > platforms without it (e.g. compile test on MIPS with RALINK and
>>  > SOC_RT305X):
>>  >
>>  >     /usr/bin/mips-linux-gnu-ld:
>>  > drivers/gpu/drm/ingenic/ingenic-drm-drv.o: in function
>>  > `ingenic_drm_bind.isra.0':
>>  >     ingenic-drm-drv.c:(.text+0x1600): undefined reference to
>>  > `clk_get_parent'
>>  >     /usr/bin/mips-linux-gnu-ld: ingenic-drm-drv.c:(.text+0x16b0):
>>  > undefined reference to `clk_get_parent'
>>  >
>>  > Reported-by: kernel test robot <lkp@intel.com>
>>  > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>> 
>>  Acked-by: Paul Cercueil <paul@crapouillou.net>
> 
> Thanks for the ack.
> 
> David and Daniel,
> I think there is no dedicated maintainer for Ingenic DRM, so can you
> pick it up directly?

I am. Pushed to drm-misc-next, thanks!

-Paul



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-12-04 10:08 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20201116175410epcas1p1c0dbe17b850b30baa05d768fbdc74f5d@epcas1p1.samsung.com>
2020-11-16 17:53 ` [PATCH 1/2] drm/exynos: depend on COMMON_CLK to fix compile tests Krzysztof Kozlowski
2020-11-16 17:53   ` [PATCH 2/2] drm/ingenic: " Krzysztof Kozlowski
2020-11-16 19:54     ` Paul Cercueil
2020-12-04  8:18       ` Krzysztof Kozlowski
2020-12-04 10:07         ` Paul Cercueil
2020-11-23  1:24   ` [PATCH 1/2] drm/exynos: " Inki Dae

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).