From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Namhyung Kim <namhyung@kernel.org>,
"Jin, Yao" <yao.jin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel <Linux-kernel@vger.kernel.org>,
Andi Kleen <ak@linux.intel.com>,
"Liang, Kan" <kan.liang@intel.com>,
"Jin, Yao" <yao.jin@intel.com>
Subject: Re: [PATCH] perf vendor events: Update Skylake client events to v50
Date: Mon, 16 Nov 2020 16:24:40 -0300 [thread overview]
Message-ID: <20201116192440.GC614220@kernel.org> (raw)
In-Reply-To: <CAP-5=fXJCqB6sN+f-eRSwc+Za3Yri+QWMpg_G7xfz=i-cTBH3A@mail.gmail.com>
Em Mon, Nov 16, 2020 at 11:12:30AM -0800, Ian Rogers escreveu:
> On Mon, Nov 16, 2020 at 9:05 AM Arnaldo Carvalho de Melo <acme@kernel.org>
> wrote:
>
> > Em Fri, Nov 06, 2020 at 01:21:58PM +0900, Namhyung Kim escreveu:
> > > On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao <yao.jin@linux.intel.com>
> > wrote:
> > > > >> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> > > > >
> > > > > It seems not applied to acme/perf/core cleanly.
> > > > >
> > > > > Thanks,
> > > > > Namhyung
> > > > >
> > > >
> > > > It seems the patch mail is truncated. :(
> > > >
> > > > I attach the patch file in the mail. Sorry for inconvenience.
> > >
> > > I've checked it fixed the perf test on my laptop (skylake).
> > >
> > > Tested-by: Namhyung Kim <namhyung@kernel.org>
> >
> > Thanks, applied.
> >
> > - Arnaldo
> >
>
> Nit, as the code is generated, would it be possible to add the commands to
> regenerate it?
>
> E.g. Using the code in:
> https://github.com/intel/event-converter-for-linux-perf
> And extracted perfmon_server_events_v1.4.tar from:
> https://download.01.org/perfmon/
> run:
> json-to-perf-json.py --outdir tools/perf/pmu-events/arch/arch/x86/sklylakex
> perfmon/SKX/skylakex_core_v1.24.json
> Looking at the download.01.org/perfmon json there are files
> like skylakex_fp_arith_inst_v1.24.json, and how these are incorporated into
> these events is less than clear.
You mean change event-converter-for-linux-perf to add this as JSON
comments at the start of the generated files?
- Arnaldo
next prev parent reply other threads:[~2020-11-16 19:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 1:51 [PATCH] perf vendor events: Update Skylake client events to v50 Jin Yao
2020-11-06 3:00 ` Namhyung Kim
2020-11-06 3:11 ` Jin, Yao
2020-11-06 4:21 ` Namhyung Kim
2020-11-13 8:12 ` Jin, Yao
2020-11-15 13:35 ` Andi Kleen
[not found] ` <CAP-5=fW-9oj4PK=hBmvrCqfzLnoqTe502FRb74Jwqpo+3KoJKw@mail.gmail.com>
2020-11-16 8:07 ` Jin, Yao
2020-11-16 14:53 ` Andi Kleen
2020-11-16 17:05 ` Arnaldo Carvalho de Melo
[not found] ` <CAP-5=fXJCqB6sN+f-eRSwc+Za3Yri+QWMpg_G7xfz=i-cTBH3A@mail.gmail.com>
2020-11-16 19:24 ` Arnaldo Carvalho de Melo [this message]
2020-11-16 21:24 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116192440.GC614220@kernel.org \
--to=acme@kernel.org \
--cc=Linux-kernel@vger.kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).