Re: [PATCH v12 15/15] iommu/smmuv3: Add PASID cache invalidation per PASID

From: kernel test robot <lkp@intel.com>
To: Eric Auger <eric.auger@redhat.com>,
	eric.auger.pro@gmail.com, iommu@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	kvmarm@lists.cs.columbia.edu, will@kernel.org, joro@8bytes.org,
	maz@kernel.org, robin.murphy@arm.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH v12 15/15] iommu/smmuv3: Add PASID cache invalidation per PASID
Date: Tue, 17 Nov 2020 00:24:53 +0800	[thread overview]
Message-ID: <202011170009.aEQOJf2k-lkp@intel.com> (raw)
In-Reply-To: <20201116104316.31816-16-eric.auger@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 4934 bytes --]

Hi Eric,

I love your patch! Perhaps something to improve:

[auto build test WARNING on iommu/next]
[also build test WARNING on linus/master v5.10-rc4 next-20201116]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Eric-Auger/SMMUv3-Nested-Stage-Setup-IOMMU-part/20201116-185039
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
config: arm64-randconfig-r034-20201115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project c044709b8fbea2a9a375e4173a6bd735f6866c0c)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/95e4ccc61b7a7c06e1e0c6c01f362d590136ad3c
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Eric-Auger/SMMUv3-Nested-Stage-Setup-IOMMU-part/20201116-185039
        git checkout 95e4ccc61b7a7c06e1e0c6c01f362d590136ad3c
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3010:8: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses]
                           if (!info->flags & IOMMU_INV_PASID_FLAGS_PASID)
                               ^            ~
   drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3010:8: note: add parentheses after the '!' to evaluate the bitwise operator first
                           if (!info->flags & IOMMU_INV_PASID_FLAGS_PASID)
                               ^
                                (                                        )
   drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c:3010:8: note: add parentheses around left hand side expression to silence this warning
                           if (!info->flags & IOMMU_INV_PASID_FLAGS_PASID)
                               ^
                               (           )
   1 warning generated.

vim +3010 drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

  2960	
  2961	static int
  2962	arm_smmu_cache_invalidate(struct iommu_domain *domain, struct device *dev,
  2963				  struct iommu_cache_invalidate_info *inv_info)
  2964	{
  2965		struct arm_smmu_domain *smmu_domain = to_smmu_domain(domain);
  2966		struct arm_smmu_device *smmu = smmu_domain->smmu;
  2967	
  2968		if (smmu_domain->stage != ARM_SMMU_DOMAIN_NESTED)
  2969			return -EINVAL;
  2970	
  2971		if (!smmu)
  2972			return -EINVAL;
  2973	
  2974		if (inv_info->version != IOMMU_CACHE_INVALIDATE_INFO_VERSION_1)
  2975			return -EINVAL;
  2976	
  2977		if (inv_info->cache & IOMMU_CACHE_INV_TYPE_IOTLB) {
  2978			if (inv_info->granularity == IOMMU_INV_GRANU_PASID) {
  2979				struct iommu_inv_pasid_info *info =
  2980					&inv_info->granu.pasid_info;
  2981	
  2982				if (!(info->flags & IOMMU_INV_PASID_FLAGS_ARCHID) ||
  2983				     (info->flags & IOMMU_INV_PASID_FLAGS_PASID))
  2984					return -EINVAL;
  2985	
  2986				__arm_smmu_tlb_inv_context(smmu_domain, info->archid);
  2987	
  2988			} else if (inv_info->granularity == IOMMU_INV_GRANU_ADDR) {
  2989				struct iommu_inv_addr_info *info = &inv_info->granu.addr_info;
  2990				size_t size = info->nb_granules * info->granule_size;
  2991				bool leaf = info->flags & IOMMU_INV_ADDR_FLAGS_LEAF;
  2992	
  2993				if (!(info->flags & IOMMU_INV_ADDR_FLAGS_ARCHID) ||
  2994				     (info->flags & IOMMU_INV_ADDR_FLAGS_PASID))
  2995					return -EINVAL;
  2996	
  2997				__arm_smmu_tlb_inv_range(info->addr, size,
  2998							 info->granule_size, leaf,
  2999							  smmu_domain, info->archid);
  3000	
  3001				arm_smmu_cmdq_issue_sync(smmu);
  3002			} else {
  3003				return -EINVAL;
  3004			}
  3005		} else if (inv_info->cache & IOMMU_CACHE_INV_TYPE_PASID) {
  3006			if (inv_info->granularity == IOMMU_INV_GRANU_PASID) {
  3007				struct iommu_inv_pasid_info *info =
  3008					&inv_info->granu.pasid_info;
  3009	
> 3010				if (!info->flags & IOMMU_INV_PASID_FLAGS_PASID)
  3011					return -EINVAL;
  3012	
  3013				arm_smmu_sync_cd(smmu_domain, info->pasid, true);
  3014			} else {
  3015				return -ENOENT;
  3016			}
  3017		} else { /* IOMMU_CACHE_INV_TYPE_DEV_IOTLB */
  3018			return -ENOENT;
  3019		}
  3020		return 0;
  3021	}
  3022	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39466 bytes --]