From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA7B9C63777 for ; Tue, 17 Nov 2020 04:16:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69B7B20780 for ; Tue, 17 Nov 2020 04:16:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CsMzAUSR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727383AbgKQEP7 (ORCPT ); Mon, 16 Nov 2020 23:15:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726827AbgKQEP7 (ORCPT ); Mon, 16 Nov 2020 23:15:59 -0500 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43C95C0613CF for ; Mon, 16 Nov 2020 20:15:59 -0800 (PST) Received: by mail-pg1-x542.google.com with SMTP id 62so15171190pgg.12 for ; Mon, 16 Nov 2020 20:15:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=5lv6RfP8qJF5zkeuOHJR2hccKAcSS2SlN9owQue64IU=; b=CsMzAUSREoHBdOFlF17Kh8CLBA0AOwM7j9djxKPsNMLczyCCKIrDjqJypaW6xrc73j BcQyU9ga/xqoTAQHq8b22DznzWXVX+olP97SKTMInqsim2q5A2Sc4qpEeTJcbZNCJlqN gxlO8zY3VjlZOwbn4WVZt8QswZ0lbWsqCevhyd1RagEUzh+sbZs7uzqcSS4rsKp7/Bqn QrJa0jxAY9duJ+c3wZqwNFs6xo8vpBfamCdHtDwrShSsHbJBIUO7BuclicfWqBzFFtQV iH0WsmGLyMTQQl2sEkC0XVH1JlcacAi7bTR7E4oVbYKTunOoTQmfGG1MEn04IIagMeqQ Mmfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=5lv6RfP8qJF5zkeuOHJR2hccKAcSS2SlN9owQue64IU=; b=cgM3stcUijFqJFBxlGJIm1sBFuErgle82KXN/U1kI6kw1/0FmZjU1j6aMy8OjRs8JI G1Pig5SZrfDtCSOSY+RIuvHGGSN+XBdNajmOtIfFKY66TvFGvDPHkvBQQYNzFw3dIgYS gqlgiiFQ6SyiHZ6BOIwzg0P/ypX+AEH0H4k4ghuNQb7BQRG5OiYxeNllb9YSP5fj19Qy U5VHvXfEDUp7pm0L8z6Zi/EPcpzpW+9ynx0UJZcwjUFuw3N9CUx0RI23K6gUDvZNO+R3 WjUaAkc0HiHLzG85C4rEAsYd9Lk+LsBwH0115NfHNd8bmNkCPqsKuHawi/AW2YbdR4Y2 apOA== X-Gm-Message-State: AOAM53010nggmYf8AQWm7tMVdJGwI0pY8zt0bQo/i60m6JSNhYprwCAJ dDMtG+MWuf2Fg4RWRqpnXCFFFg== X-Google-Smtp-Source: ABdhPJxZI7TLqwlvaZVVQPdPJ1Gdy8UhRZbKM9zVBUc3nS3eQPpIbSfErrRc2XuX/2Su3/fPCDTuOw== X-Received: by 2002:a62:5e06:0:b029:164:a9ca:b07e with SMTP id s6-20020a625e060000b0290164a9cab07emr16459338pfb.36.1605586558858; Mon, 16 Nov 2020 20:15:58 -0800 (PST) Received: from localhost ([122.172.12.172]) by smtp.gmail.com with ESMTPSA id 131sm3889341pfw.117.2020.11.16.20.15.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Nov 2020 20:15:58 -0800 (PST) Date: Tue, 17 Nov 2020 09:45:55 +0530 From: Viresh Kumar To: "Rafael J. Wysocki" Cc: Linux PM , LKML , Srinivas Pandruvada , Zhang Rui Subject: Re: [PATCH] cpufreq: schedutil: Simplify sugov_update_next_freq() Message-ID: <20201117041555.s6x7wpjpnhfq7y3m@vireshk-i7> References: <25503091.Kiabxektef@kreacher> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25503091.Kiabxektef@kreacher> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12-11-20, 20:26, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Rearrange a conditional to make it more straightforward. > > Signed-off-by: Rafael J. Wysocki > --- > kernel/sched/cpufreq_schedutil.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > Index: linux-pm/kernel/sched/cpufreq_schedutil.c > =================================================================== > --- linux-pm.orig/kernel/sched/cpufreq_schedutil.c > +++ linux-pm/kernel/sched/cpufreq_schedutil.c > @@ -102,12 +102,10 @@ static bool sugov_should_update_freq(str > static bool sugov_update_next_freq(struct sugov_policy *sg_policy, u64 time, > unsigned int next_freq) > { > - if (!sg_policy->need_freq_update) { > - if (sg_policy->next_freq == next_freq) > - return false; > - } else { > + if (sg_policy->need_freq_update) > sg_policy->need_freq_update = cpufreq_driver_test_flags(CPUFREQ_NEED_UPDATE_LIMITS); > - } > + else if (sg_policy->next_freq == next_freq) > + return false; > > sg_policy->next_freq = next_freq; > sg_policy->last_freq_update_time = time; > Acked-by: Viresh Kumar -- viresh