From: Jakub Kicinski <kuba@kernel.org>
To: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Zhang Changzhong <zhangchangzhong@huawei.com>,
jcliburn@gmail.com, chris.snook@gmail.com, davem@davemloft.net,
hkallweit1@gmail.com, yanaijie@huawei.com, mst@redhat.com,
leon@kernel.org, jesse.brandeburg@intel.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] atl1c: fix error return code in atl1c_probe()
Date: Tue, 17 Nov 2020 12:45:25 -0800 [thread overview]
Message-ID: <20201117124525.5c4b28b0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> (raw)
In-Reply-To: <83ee32e6-9460-a1f1-8065-6e737edb5402@wanadoo.fr>
On Tue, 17 Nov 2020 21:39:05 +0100 Marion & Christophe JAILLET wrote:
> Le 17/11/2020 à 03:55, Zhang Changzhong a écrit :
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API")
> Hi, should it have any importance, the Fixes tag is wrong.
>
> The issue was already there before 85eb5bc33717 which was just a
> mechanical update.
Can you provide the correct one, then?
I can switch it when applying.
next prev parent reply other threads:[~2020-11-17 20:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 2:55 [PATCH net] atl1c: fix error return code in atl1c_probe() Zhang Changzhong
2020-11-17 7:14 ` Heiner Kallweit
2020-11-17 7:43 ` Chris Snook
2020-11-17 9:01 ` Heiner Kallweit
2020-11-17 9:21 ` Chris Snook
2020-11-17 20:39 ` Marion & Christophe JAILLET
2020-11-17 20:45 ` Jakub Kicinski [this message]
2020-11-18 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117124525.5c4b28b0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net \
--to=kuba@kernel.org \
--cc=chris.snook@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=jcliburn@gmail.com \
--cc=jesse.brandeburg@intel.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=yanaijie@huawei.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).