From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E492C56202 for ; Tue, 17 Nov 2020 12:51:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACCE52222E for ; Tue, 17 Nov 2020 12:51:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="N69vzxl0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728259AbgKQMuo (ORCPT ); Tue, 17 Nov 2020 07:50:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:51346 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725779AbgKQMuo (ORCPT ); Tue, 17 Nov 2020 07:50:44 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15D202222A; Tue, 17 Nov 2020 12:50:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605617443; bh=nufKKNFjFQgQkEMjmPmhWQ5WpTuzpxY2cQYNBOxXtvw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=N69vzxl0MfEp6K0J8nWD/oHBlrXt2aKh63pblyDpKkFy4aM2J6J3oOjS/ifj3npx7 tzUyJXJRI43WVfUVFrNNpVHKKyH+471CyxE3OuIpaSb8RPF/Dvd4kwhfLrLfcdRoI9 1rO9b7QpdIfk0tsDRm2jojwPk5vt3fWCSY9CwG/8= Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 0744D40E29; Tue, 17 Nov 2020 09:50:41 -0300 (-03) Date: Tue, 17 Nov 2020 09:50:40 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: lkml , Peter Zijlstra , Ingo Molnar , Mark Rutland , Namhyung Kim , Alexander Shishkin , Michael Petlan , Song Liu , Ian Rogers , Stephane Eranian , Alexey Budankov , Andi Kleen , Adrian Hunter Subject: Re: [PATCH 23/24] perf buildid-list: Add support for mmap2's buildid events Message-ID: <20201117125040.GT614220@kernel.org> References: <20201117110053.1303113-1-jolsa@kernel.org> <20201117110053.1303113-24-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117110053.1303113-24-jolsa@kernel.org> X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Nov 17, 2020 at 12:00:52PM +0100, Jiri Olsa escreveu: > Add buildid-list support for mmap2's build id data, so we can > display build ids for dso objects for data without the build > id cache update. > $ perf buildid-list > 1805c738c8f3ec0f47b7ea09080c28f34d18a82b /usr/lib64/ld-2.31.so > d278249792061c6b74d1693ca59513be1def13f2 /usr/lib64/libc-2.31.so > > By default only dso objects with hits are shown. Would be interesting to be able to show all the build ids that are there. a 'perf buildid-list --all' or make this under --force? - Arnaldo > Signed-off-by: Jiri Olsa > --- > tools/perf/builtin-buildid-list.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c > index e3ef75583514..87f5b1a4a7fa 100644 > --- a/tools/perf/builtin-buildid-list.c > +++ b/tools/perf/builtin-buildid-list.c > @@ -77,6 +77,9 @@ static int perf_session__list_build_ids(bool force, bool with_hits) > perf_header__has_feat(&session->header, HEADER_AUXTRACE)) > with_hits = false; > > + if (!perf_header__has_feat(&session->header, HEADER_BUILD_ID)) > + with_hits = true; > + > /* > * in pipe-mode, the only way to get the buildids is to parse > * the record stream. Buildids are stored as RECORD_HEADER_BUILD_ID > -- > 2.26.2 > -- - Arnaldo