From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB1BFC63697 for ; Tue, 17 Nov 2020 21:51:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8BEF9241A7 for ; Tue, 17 Nov 2020 21:51:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="dZSJWDKn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbgKQVvq (ORCPT ); Tue, 17 Nov 2020 16:51:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727701AbgKQVvq (ORCPT ); Tue, 17 Nov 2020 16:51:46 -0500 Received: from mail-pg1-x543.google.com (mail-pg1-x543.google.com [IPv6:2607:f8b0:4864:20::543]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C6FBC0613CF for ; Tue, 17 Nov 2020 13:51:46 -0800 (PST) Received: by mail-pg1-x543.google.com with SMTP id q28so6408269pgk.1 for ; Tue, 17 Nov 2020 13:51:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ky/CMCEHw6W83Pli0RSEtI4judjYnXP8NLTqyncoiBE=; b=dZSJWDKnArBdBXCgAIPNiaxvh5LCZwCDL6Ymkj44p0R8yL+KgQAfKZKf1lt2KfdnvV bLD1xeFdcoEmB+Z3tmSxV7RnFUrRITgkpS48Ri05VZa2xyqn5gWggufKXfTSH6J5m6de NMkUQrd2oc7jz3d1V4DoMoucn5sXNnsH3BN6Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ky/CMCEHw6W83Pli0RSEtI4judjYnXP8NLTqyncoiBE=; b=RY0DsNNvstfv3KPE50VA4sb044HgABR2Fcjm7Dtk867J6UPehZ+W2E7PcmYz1Lubad fYxD0FZsy6g6LcHDsxFOjTT2NI8bydXkEjZuk4chT8NYKUWS5o683AeEwb2S+eA7JEXm N6s2gFxOxYIyiNNt3FgBntrnLXRRhAglVl+NGYkj6MmFoKMG/+M7X+rSHW0fxx3JEBF1 XqQaxoRSvFqlZpv656s71kyVt3KRLORt2nDOeH2xH8Mggbi+x6TsQmi/axlL8jLVcW2s MWK5MTA2PhywFn21SUDrd+OTtnx0hC/ti2OCLFg1QQANq0CDlQHFX8nnGkV8js8LV8LN DgdA== X-Gm-Message-State: AOAM533vZNXRuG1D83vqp5bmDVIAsBehJnI90mSyf3vNcdicEnntKfR8 P6IEUCUxQbot2FxkqUO1QGmunw== X-Google-Smtp-Source: ABdhPJxqggVKuH8HMTgHzwSVLvkZKhOmwN0EoIzciqR8uEi7NDnZHbJFTVTL+MdWrPbHDgwOP+UNwA== X-Received: by 2002:a63:7847:: with SMTP id t68mr5290408pgc.422.1605649905676; Tue, 17 Nov 2020 13:51:45 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id m9sm42912pjf.20.2020.11.17.13.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 13:51:44 -0800 (PST) Date: Tue, 17 Nov 2020 13:51:43 -0800 From: Kees Cook To: Nathan Chancellor Cc: Masahiro Yamada , Michal Marek , Russell King , Catalin Marinas , Will Deacon , Michael Ellerman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, Nick Desaulniers , Arvind Sankar , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, clang-built-linux@googlegroups.com, "kernelci . org bot" , Mark Brown Subject: Re: [PATCH 2/2] kbuild: Disable CONFIG_LD_ORPHAN_WARN for ld.lld 10.0.1 Message-ID: <202011171350.F95127F@keescook> References: <20201113195553.1487659-1-natechancellor@gmail.com> <20201113195553.1487659-2-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201113195553.1487659-2-natechancellor@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 13, 2020 at 12:55:53PM -0700, Nathan Chancellor wrote: > config LD_ORPHAN_WARN > - def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) > + def_bool ARCH_WANT_LD_ORPHAN_WARN && $(ld-option,--orphan-handling=warn) && (!LD_IS_LLD || LLD_VERSION >= 110000) Readability nit-pick... I prefer separate "depends" lines to make things a little easier to parse, change, etc: config LD_ORPHAN_WARN def_bool y depends on ARCH_WANT_LD_ORPHAN_WARN depends on !LD_IS_LLD || LLD_VERSION >= 110000 depends on $(ld-option,--orphan-handling=warn) Otherwise, yeah, looks good to me. With this and the other suggestions, please consider it: Reviewed-by: Kees Cook -- Kees Cook