From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18C75C56202 for ; Tue, 17 Nov 2020 14:43:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C76222222E for ; Tue, 17 Nov 2020 14:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728916AbgKQOnz (ORCPT ); Tue, 17 Nov 2020 09:43:55 -0500 Received: from outbound-smtp24.blacknight.com ([81.17.249.192]:55616 "EHLO outbound-smtp24.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728285AbgKQOnz (ORCPT ); Tue, 17 Nov 2020 09:43:55 -0500 Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp24.blacknight.com (Postfix) with ESMTPS id C2C83C0F11 for ; Tue, 17 Nov 2020 14:43:53 +0000 (GMT) Received: (qmail 31257 invoked from network); 17 Nov 2020 14:43:53 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.22.4]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 17 Nov 2020 14:43:53 -0000 Date: Tue, 17 Nov 2020 14:43:52 +0000 From: Mel Gorman To: Peter Zijlstra Cc: LKML , Ingo Molnar , Vincent Guittot , Valentin Schneider , Juri Lelli Subject: Re: [PATCH 2/3] sched/numa: Allow a floating imbalance between NUMA nodes Message-ID: <20201117144352.GZ3371@techsingularity.net> References: <20201117134222.31482-1-mgorman@techsingularity.net> <20201117134222.31482-3-mgorman@techsingularity.net> <20201117141603.GM3121392@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20201117141603.GM3121392@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 17, 2020 at 03:16:03PM +0100, Peter Zijlstra wrote: > On Tue, Nov 17, 2020 at 01:42:21PM +0000, Mel Gorman wrote: > > This patch revisits the possibility that NUMA nodes can be imbalanced > > until 25% of the CPUs are occupied. The reasoning behind 25% is somewhat > > superficial -- it's half the cores when HT is enabled. At higher > > utilisations, balancing should continue as normal and keep things even > > until scheduler domains are fully busy or over utilised. > > Do we want to make that shift depend on the actual SMT factor? I considered it but decided against it. I wanted the balance point to be somewhere below SMT because select_idle_sibling tries to avoid SMT sharing so I didn't want a point where SMT sharing caused more problems than memory locality. However, I worried that picking a different imbalance point depending on SMT would be surprising to some. -- Mel Gorman SUSE Labs