From: Hui Su <sh_def@163.com>
To: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: sh_def@163.com
Subject: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru()
Date: Wed, 18 Nov 2020 01:12:42 +0800 [thread overview]
Message-ID: <20201117171242.GA120587@rlk> (raw)
lru_list lru bit 0 can tell whether the list is
avtive lru-list or not.
lru_list lru bit 1 can tell whether the list is
file lru-list or not.
And fix some define type in shrink_active_list()
and get_scan_count().
v1->v2:
correct the commit message, and fix the define type.
Signed-off-by: Hui Su <sh_def@163.com>
---
include/linux/mmzone.h | 4 ++--
mm/vmscan.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index fb3bf696c05e..294369c652d0 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -258,12 +258,12 @@ enum lru_list {
static inline bool is_file_lru(enum lru_list lru)
{
- return (lru == LRU_INACTIVE_FILE || lru == LRU_ACTIVE_FILE);
+ return lru & LRU_FILE;
}
static inline bool is_active_lru(enum lru_list lru)
{
- return (lru == LRU_ACTIVE_ANON || lru == LRU_ACTIVE_FILE);
+ return lru & LRU_ACTIVE;
}
#define ANON_AND_FILE 2
diff --git a/mm/vmscan.c b/mm/vmscan.c
index 7b4e31eac2cf..7d8ea2fc87fc 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -2020,7 +2020,7 @@ static void shrink_active_list(unsigned long nr_to_scan,
struct page *page;
unsigned nr_deactivate, nr_activate;
unsigned nr_rotated = 0;
- int file = is_file_lru(lru);
+ bool file = is_file_lru(lru);
struct pglist_data *pgdat = lruvec_pgdat(lruvec);
lru_add_drain();
@@ -2323,7 +2323,7 @@ static void get_scan_count(struct lruvec *lruvec, struct scan_control *sc,
denominator = ap + fp;
out:
for_each_evictable_lru(lru) {
- int file = is_file_lru(lru);
+ bool file = is_file_lru(lru);
unsigned long lruvec_size;
unsigned long scan;
unsigned long protection;
--
2.29.0
next reply other threads:[~2020-11-17 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-17 17:12 Hui Su [this message]
2020-11-17 17:41 ` [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Matthew Wilcox
2020-11-17 17:46 ` Hui Su
2020-11-17 17:47 ` Matthew Wilcox
2020-11-17 17:56 ` Hui Su
2020-11-17 17:59 ` Matthew Wilcox
2020-11-17 18:05 ` Hui Su
2020-11-20 19:08 ` Hui Su
-- strict thread matches above, loose matches on Subject: below --
2020-11-17 16:49 Hui Su
2020-11-17 16:53 ` Hui Su
2020-11-17 17:40 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117171242.GA120587@rlk \
--to=sh_def@163.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).