From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22033C2D0E4 for ; Tue, 17 Nov 2020 17:41:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACBE6206B6 for ; Tue, 17 Nov 2020 17:41:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Ly0DsO0O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729968AbgKQRlY (ORCPT ); Tue, 17 Nov 2020 12:41:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726597AbgKQRlV (ORCPT ); Tue, 17 Nov 2020 12:41:21 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12233C0613CF for ; Tue, 17 Nov 2020 09:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pmBYhBP5We7GHGzGu7owER3LNkD4Ikjk91kiljzGJ1A=; b=Ly0DsO0Od8hd/O0w73TWUTZ4OL KLc9lwwwMr/shGjFc79zunjo56JgO3xLEIUrfL3/V4hb2roYpW/MwSYmqkfWnyzS3v4YlTxLEDU+h PL50OnLgRzvoDo3wk34eVivQ2J0aaUxJQ4xkRpbBrLEhlAKApI+7lkyf+xMQABT8eEocrf1mzNlEt cfRrtlLM/D1tFbBP87Pk7CTHGCCqoNAmgyLWaZT2Lmd/qqI2RRj29hib8Lk6UizBvbG2KmP+xVaBM zA34VcYBEmorDo4fOsmkjB2jxEOhJQTavW3wEMOsvY9iP4w4p8DCXdL307hr32yGFJ+QY8NJTqadK 3p8QLkuw==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf4yj-0006oy-DL; Tue, 17 Nov 2020 17:41:17 +0000 Date: Tue, 17 Nov 2020 17:41:17 +0000 From: Matthew Wilcox To: Hui Su Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/lru: simplify is_file_lru() and is_active_lru() Message-ID: <20201117174117.GQ29991@casper.infradead.org> References: <20201117171242.GA120587@rlk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201117171242.GA120587@rlk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 18, 2020 at 01:12:42AM +0800, Hui Su wrote: > lru_list lru bit 0 can tell whether the list is > avtive lru-list or not. > lru_list lru bit 1 can tell whether the list is > file lru-list or not. > > And fix some define type in shrink_active_list() > and get_scan_count(). > > v1->v2: > correct the commit message, and fix the define type. No, still incorrect.