linux-next: Fixes tag needs some work in the v4l-dvb tree

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2053 bytes --]

Hi all,

In commit

  cf7f34777a5b ("media: vim2m: Register video device after setting up internals")

Fixes tag

  Fixes: commit 96d8eab5d0a1 ("V4L/DVB: [v5,2/2] v4l: Add a mem-to-mem videobuf framework test device")

has these problem(s):

  - leading word 'commit' unexpected

In commit

  eff5ce02e170 ("media: venus: put dummy vote on video-mem path after last session release")

Fixes tag

  Fixes: 07f8f22a33a9e ("media: venus: core: remove CNOC voting while device

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes: tags over more than one line. (And the second
line of *above* the first :-()

In commit

  e44fb034b032 ("media: venus: core: vote with average bandwidth and peak bandwidth as zero")

Fixes tag

  Fixes: 07f8f22a33a9e ("media: venus: core: remove CNOC voting while device

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes: tags over more than one line. (And the second
line of *above* the first :-()

In commit

  9e8efdb57879 ("media: venus: core: vote for video-mem path")

Fixes tag

  Fixes: 07f8f22a33a9e ("media: venus: core: remove CNOC voting while device

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes: tags over more than one line. (And the second
line of *above* the first :-()

In commit

  21926d466e3a ("media: venus: core: change clk enable and disable order in resume and suspend")

Fixes tag

  Fixes: 07f8f22a33a9e ("media: venus: core: remove CNOC voting while device

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes: tags over more than one line. (And the second
line of *above* the first :-()

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi all,

In commit

  fda0f59a3aa4 ("media: ov7251: Fix multiple problems in s_stream callback")

Fixes tag

  Fixes: ("media: i2c: Add pm_runtime support to ov7251")

has these problem(s):

  - No SHA1 recognised

Maybe you meant

Fixes: 207f4162f1c9 ("media: i2c: Add pm_runtime support to ov7251")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi all,

In commit

  106be65a4119 ("media: mediatek: vcodec: decoder: Const-ify stepwise_fhd")

Fixes tag

  Fixes: ("76250b48de79 media: mediatek: vcodec: Getting supported decoder format types")

has these problem(s):

  - No SHA1 recognised

Please just use

  git log -1 --format='Fixes: %h ("%s")' <commit>

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 455 bytes --]

Hi all,

In commit

  16a5dcf7fbc2 ("media: atomisp: Fixed error handling path")

Fixes tag

  Fixes: 14a638ab96c5 ("media: atomisp: use pin_user_pages() for memory

has these problem(s):

  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than one line.  Split tags get
mishandles (as has happened here with the second line being moved above
the rest of the tags).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 484 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

Hi all,

In commit

  18ffec750578 ("media: exynos4-is: Add missed check for pinctrl_lookup_state()")

Fixes tag

  Fixes: 4163851f7b99 ("[media] s5p-fimc: Use pinctrl API for camera ports configuration]")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 374 bytes --]

Hi all,

In commit

  de99280b2640 ("media: atomisp: add a notice about possible leak resources")

Fixes tag

  Fixes: 88b03de5d705 ("media: atomisp: Add some ACPI detection info")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: ea073ef04fb3 ("media: atomisp: Add some ACPI detection info")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi all,

In commit

  70d4a9efee9c ("media: entity: Pass entity to get_fwnode_pad operation")

Fixes tag

  Fixes: ae45cd5efc120 ("[media] media: entity: Add get_fwnode_pad entity

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags over more than 1 line.  The second part
of this one has also been moved in the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi all,

In commit

  ab07b1a6ac6e ("media: omap3isp: Prevent enabling CCDC when stopping streaming")

Fixes tag

  Fixes: dd12ed17ce9e ("omap3isp: Don't restart CCDC if we're about to stop")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

Also, please keep all the commit message tags together at the end of
the commit message.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

In commit

  1dc8b65c944e ("media: v4l2-core: only zero-out ioctl-read buffers")

Fixes tag

  Fixes: 6c625c01c7a6 ("media: v4l2-core: split out data copy from video_usercopy")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: c8ef1a6076bf ("media: v4l2-core: split out data copy from video_usercopy")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the v4l-dvb tree

[Benoit Parrot]

Stephen Rothwell <sfr@canb.auug.org.au> wrote on Fri [2019-Oct-11 07:47:02 +1100]:
> Hi all,
> 
> In commit
> 
>   e20b248051ca ("media: ti-vpe: vpe: Make sure YUYV is set as default format")
> 
> Fixes tag
> 
>   Fixes: 40cc823f7005 ("media: ti-vpe: Add support for NV21 format")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: b2bb3d822f2c ("media: ti-vpe: Add support for NV21 format")

Ah, yes.
This was obviously missed through the rebase, sorry.

Benoit

> 
> -- 
> Cheers,
> Stephen Rothwell

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi all,

In commit

  e20b248051ca ("media: ti-vpe: vpe: Make sure YUYV is set as default format")

Fixes tag

  Fixes: 40cc823f7005 ("media: ti-vpe: Add support for NV21 format")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: b2bb3d822f2c ("media: ti-vpe: Add support for NV21 format")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Hi Mauro,

In commit

  3a959dcd11a4 ("media: mt9m111: add regulator support")

Fixes tag

  Fixes: 5c10113cc668 ("media: mt9m111: make a standalone v4l2 subdevice")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

  5d7cc01b20fc ("[media] media: mt9m111: make a standalone v4l2 subdevice")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the v4l-dvb tree

[Mauro Carvalho Chehab]

Em Wed, 29 May 2019 23:05:11 +0200
"Niklas Söderlund" <niklas.soderlund@ragnatech.se> escreveu:

> Hi Stephen, Mauro,
> 
> On 2019-05-29 08:04:54 +1000, Stephen Rothwell wrote:
> > Hi Mauro,
> > 
> > In commit
> > 
> >   0c310868826e ("media: rcar-csi2: Fix coccinelle warning for PTR_ERR_OR_ZERO()")
> > 
> > Fixes tag
> > 
> >   Fixes: 3ae854cafd76 ("rcar-csi2: Use standby mode instead of resetting")
> > 
> > has these problem(s):
> > 
> >   - Target SHA1 does not exist
> > 
> > Did you mean
> > 
> > Fixes: d245a940d97b ("media: rcar-csi2: Use standby mode instead of resetting")  
> 
> Yes I meant d245a940d97b commit, for some reason I was on the wrong 
> branch when looking up the sha1 for the fixes tag and used one from a 
> local development branch.
> 
> This is my mess, sorry about that. What can I do to help fix it?

That's a good question... no idea. Rebasing the tree due to that sounds
a bad idea. Reverting/reapplying also doesn't sound the best thing,
as it will just make -stable people even more confused.

I should probably try to implement a script like the one Stephen
has on my patch import scripts.

Thanks,
Mauro

Re: linux-next: Fixes tag needs some work in the v4l-dvb tree

[Niklas Söderlund]

Hi Stephen, Mauro,

On 2019-05-29 08:04:54 +1000, Stephen Rothwell wrote:
> Hi Mauro,
> 
> In commit
> 
>   0c310868826e ("media: rcar-csi2: Fix coccinelle warning for PTR_ERR_OR_ZERO()")
> 
> Fixes tag
> 
>   Fixes: 3ae854cafd76 ("rcar-csi2: Use standby mode instead of resetting")
> 
> has these problem(s):
> 
>   - Target SHA1 does not exist
> 
> Did you mean
> 
> Fixes: d245a940d97b ("media: rcar-csi2: Use standby mode instead of resetting")

Yes I meant d245a940d97b commit, for some reason I was on the wrong 
branch when looking up the sha1 for the fixes tag and used one from a 
local development branch.

This is my mess, sorry about that. What can I do to help fix it?

-- 
Regards,
Niklas Söderlund

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi Mauro,

In commit

  0c310868826e ("media: rcar-csi2: Fix coccinelle warning for PTR_ERR_OR_ZERO()")

Fixes tag

  Fixes: 3ae854cafd76 ("rcar-csi2: Use standby mode instead of resetting")

has these problem(s):

  - Target SHA1 does not exist

Did you mean

Fixes: d245a940d97b ("media: rcar-csi2: Use standby mode instead of resetting")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 463 bytes --]

Hi Mauro,

In commit

  dad7e270ba71 ("media: vivid: use vfree() instead of kfree() for dev->bitmap_cap")

Fixes tag

  Fixes: ef834f7836ec0 ("[media] vivid: add the video capture and output

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not split Fixes tags across more than one line.  Also, keep
all the tags on one group.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the v4l-dvb tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 383 bytes --]

[I am experimenting with checking the Fixes tags in commits in linux-next.
Please let me know if you think I am being too strict.]

Hi Mauro,

Commit

  961304d17a61 ("media: dt-bindings: media: i2c: Fix i2c address for OV5645 camera sensor")

has a malformed Fixes tag.

The subject in the Fixes tag is usually surrounded by (" and ").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]