From: Matthew Wilcox <willy@infradead.org>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
Paolo Bonzini <pbonzini@redhat.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 2/2] kernel-doc: Handle function typedefs without asterisks
Date: Tue, 17 Nov 2020 21:30:51 +0000 [thread overview]
Message-ID: <20201117213051.GA29991@casper.infradead.org> (raw)
In-Reply-To: <20201117212452.GM1235237@habkost.net>
On Tue, Nov 17, 2020 at 04:24:52PM -0500, Eduardo Habkost wrote:
> On Fri, Nov 13, 2020 at 10:39:12PM +0000, Matthew Wilcox wrote:
> > Better ... can we have a test suite for the regexes and make patches to
> > them include updates to the test suite? They have clearly passed the
> > point of human understanding ;-)
>
> Would a simple black box test script like this be desirable?
I think this is fantastic! Yes please!
Can I add one more test case?
/**
* radix_tree_lookup_slot - lookup a slot in a radix tree
* @root: radix tree root
* @index: index key
*
* Returns: the slot corresponding to the position @index in the
* radix tree @root. This is useful for update-if-exists operations.
*
* This function can be called under rcu_read_lock iff the slot is not
* modified by radix_tree_replace_slot(), otherwise it must be called
* exclusive from other writers. Any dereference of the slot must be done
* using radix_tree_deref_slot().
*/
void __rcu **radix_tree_lookup_slot(const struct radix_tree_root *root,
unsigned long index)
{ }
(we used to have a problem with multiple '*' in the return type, and
we've also had problems with adornments like __rcu)
next prev parent reply other threads:[~2020-11-17 21:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 14:47 [PATCH 0/2] kernel-doc: Handle function typedefs Paolo Bonzini
2020-10-30 14:47 ` [PATCH 1/2] kernel-doc: Handle function typedefs that return pointers Paolo Bonzini
2020-10-30 14:47 ` [PATCH 2/2] kernel-doc: Handle function typedefs without asterisks Paolo Bonzini
2020-11-13 22:21 ` Jonathan Corbet
2020-11-13 22:35 ` Paolo Bonzini
2020-11-13 22:39 ` Matthew Wilcox
2020-11-17 21:24 ` Eduardo Habkost
2020-11-17 21:30 ` Matthew Wilcox [this message]
2020-11-17 22:36 ` [RFC] Add kernel-doc test script Eduardo Habkost
2020-11-18 0:23 ` Randy Dunlap
2020-11-18 13:03 ` Eduardo Habkost
2020-11-18 16:32 ` Randy Dunlap
2020-11-18 16:57 ` Eduardo Habkost
2020-11-18 16:58 ` Randy Dunlap
2020-11-18 8:21 ` Paolo Bonzini
2020-11-18 12:05 ` Eduardo Habkost
2020-11-18 16:27 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201117213051.GA29991@casper.infradead.org \
--to=willy@infradead.org \
--cc=corbet@lwn.net \
--cc=ehabkost@redhat.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).