From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5FFCC5519F for ; Wed, 18 Nov 2020 05:28:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6028824655 for ; Wed, 18 Nov 2020 05:28:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HVHOpkt/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726455AbgKRF2d (ORCPT ); Wed, 18 Nov 2020 00:28:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbgKRF2d (ORCPT ); Wed, 18 Nov 2020 00:28:33 -0500 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06A63C0613D4 for ; Tue, 17 Nov 2020 21:28:33 -0800 (PST) Received: by mail-pl1-x641.google.com with SMTP id b3so359405pls.11 for ; Tue, 17 Nov 2020 21:28:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=i7NQcmg0sYY8A0xlzCx+NZowN/eNGNUoVY/o8X/i+jY=; b=HVHOpkt/qqNt9sE6chv3U7ohVXbszeie0CQi5JUw5PUCYb4Q8G/UdR3X+kkmQ45kKt Em/Cnv12xCd9dU5raew3gzyMlRZ1vSpv2v5EJ2ubv3k25i7cQWfuyJojAKDsfus2pQAw L07ZygsSRdwZthKV63A0oOgdzRd7y6vebdXXytZPb+YoVKKa/BR8DxngpQTYRcrGLqcm 6e31dz04CuMnlD9QbqCaMqbWP3aACS5ya1bCz7VeFlQWY/w2/qJXSGX8O7PywPyTB63R iM/93VxE9HYXfTZvbaB+w4XthiYuzpDSk/lxJhpdZ/hCCVoxlEYIGf7DocxfiyqduRJI PDlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=i7NQcmg0sYY8A0xlzCx+NZowN/eNGNUoVY/o8X/i+jY=; b=A8OE+8Mi2ksMTK3bSwV8rV0oAq7CObiHA1WjBHarTuxv4TH2XkIvI6J0gOLURvs9Wu MWxmFeWk6bKOp3uI2L1teVjCsTUFw2WYcSQZs88w+zhexssrXmrAyWk6W3t7DJcVrSC4 EELl/qjc0U++3NJ7cwMQjVMOFBypPpKJGgZrilaS/rdup1tkkYhDqK0bMnZmGYIXwE1+ w74d5Gr/MiNFiqXp9+543fi63D2CU9NCvgPXxdlONjM4Awu/CE38MedgSzY5tBvr52hd e3+KChl/wrGJgrDAlb40NXLEE3D8tR7CpdwBOThDElaVz4XgY3p0MUYlwSr2HhsQ2jhV DceQ== X-Gm-Message-State: AOAM533tLW9ZLGWYkw8cOxrWGB5V31uvCJcr71Het+4KYHZ60DQx2skz 7fFY1aiwOVZEGwND8Mp1uQHv2F/ijLTpQw== X-Google-Smtp-Source: ABdhPJwE3hBbeNtRV7Zgs+1PM2OnxpXYUaUyaPcW0+rjSjJgGdij1UAnuyebd9b/G+OtrU4TJCHdpA== X-Received: by 2002:a17:902:8d82:b029:d8:c5e8:9785 with SMTP id v2-20020a1709028d82b02900d8c5e89785mr2704949plo.5.1605677312497; Tue, 17 Nov 2020 21:28:32 -0800 (PST) Received: from localhost ([122.172.12.172]) by smtp.gmail.com with ESMTPSA id w127sm23328945pfc.172.2020.11.17.21.28.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Nov 2020 21:28:31 -0800 (PST) Date: Wed, 18 Nov 2020 10:58:29 +0530 From: Viresh Kumar To: Rob Clark Cc: Daniel Vetter , dri-devel , Rob Clark , Sean Paul , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , "Menon, Nishanth" Subject: Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path Message-ID: <20201118052829.ugt7i7ac6eqsj4l6@vireshk-i7> References: <20201022080644.2ck4okrxygmkuatn@vireshk-i7> <20201027113532.nriqqws7gdcu5su6@vireshk-i7> <20201103054715.4l5j57pyjz6zd6ed@vireshk-i7> <20201104030353.ny7zvakgb4fsye6r@vireshk-i7> <20201106071621.j732gt4nqifjrccd@vireshk-i7> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-11-20, 09:02, Rob Clark wrote: > With that on top of the previous patch, Don't you still have this ? Which fixed the lockdep in the remove path. https://lore.kernel.org/lkml/20201022080644.2ck4okrxygmkuatn@vireshk-i7/ To make it clear you need these patches to fix the OPP stuff: //From 5.10-rc3 (the one from the above link). commit e0df59de670b ("opp: Reduce the size of critical section in _opp_table_kref_release()") //Below two from linux-next commit ef43f01ac069 ("opp: Always add entries in dev_list with opp_table->lock held") commit 27c09484dd3d ("opp: Allocate the OPP table outside of opp_table_lock") This matches the diff I gave you earlier. -- viresh