From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C432C5519F for ; Wed, 18 Nov 2020 10:02:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F07B20738 for ; Wed, 18 Nov 2020 10:02:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727061AbgKRKC2 (ORCPT ); Wed, 18 Nov 2020 05:02:28 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:52089 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725613AbgKRKC1 (ORCPT ); Wed, 18 Nov 2020 05:02:27 -0500 Received: from ip5f5af0a0.dynamic.kabel-deutschland.de ([95.90.240.160] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kfKID-00037N-TN; Wed, 18 Nov 2020 10:02:26 +0000 Date: Wed, 18 Nov 2020 11:02:25 +0100 From: Christian Brauner To: Giuseppe Scrivano Cc: linux-kernel@vger.kernel.org, linux@rasmusvillemoes.dk, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, containers@lists.linux-foundation.org Subject: Re: [PATCH v2 0/2] fs, close_range: add flag CLOSE_RANGE_CLOEXEC Message-ID: <20201118100225.5sdsourja7ec5fyn@wittgenstein> References: <20201019102654.16642-1-gscrivan@redhat.com> <20201029153859.numo2fc42vgf3ppk@wittgenstein> <87mu05vv0m.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87mu05vv0m.fsf@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 05:47:53PM +0100, Giuseppe Scrivano wrote: > Hi Christian, > > Christian Brauner writes: > > > On Mon, Oct 19, 2020 at 12:26:52PM +0200, Giuseppe Scrivano wrote: > >> When the new flag is used, close_range will set the close-on-exec bit > >> for the file descriptors instead of close()-ing them. > >> > >> It is useful for e.g. container runtimes that want to minimize the > >> number of syscalls used after a seccomp profile is installed but want > >> to keep some fds open until the container process is executed. > >> > >> v1->v2: > >> * move close_range(..., CLOSE_RANGE_CLOEXEC) implementation to a separate function. > >> * use bitmap_set() to set the close-on-exec bits in the bitmap. > >> * add test with rlimit(RLIMIT_NOFILE) in place. > >> * use "cur_max" that is already used by close_range(..., 0). > > > > I'm picking this up for some testing, thanks > > Christian > > thanks! I've addressed the comments you had for v2 and pushed them > here[1] but I've not sent yet v3 as I was waiting for a feedback from Al > whether using bitmap_set() is fine. Send it please. Christian