From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A782EC6379D for ; Wed, 18 Nov 2020 18:49:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E792246BE for ; Wed, 18 Nov 2020 18:49:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="TrLhsOI/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbgKRStB (ORCPT ); Wed, 18 Nov 2020 13:49:01 -0500 Received: from mail.kernel.org ([198.145.29.99]:56102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726527AbgKRStA (ORCPT ); Wed, 18 Nov 2020 13:49:00 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1F897246B9; Wed, 18 Nov 2020 18:48:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605725339; bh=L/3ZL6DbNpQF471NNWS0yqhwfXXZnzfqsalBwXDaaNY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TrLhsOI/tXpfQfbZ09WfCbElHt7PcnfdKVPNY13ZcU1QUoQ2XKD7p6D/G9xI2+mGZ wPx+/Hjuq5/cSuhx9ikihZhufpMuH9Nnk2Pr7MlOYphB1pOwWaH5M+0jMnSLUfJDD9 1y+iz1S6DXNwKhL9xJI7D/ARrcvcqC6/qJ+Ipyzw= Date: Wed, 18 Nov 2020 10:48:58 -0800 From: Jakub Kicinski To: Simon Horman Cc: "Gustavo A. R. Silva" , "David S. Miller" , oss-drivers@netronome.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] nfp: tls: Fix unreachable code issue Message-ID: <20201118104858.283cfd87@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201117200646.GA10136@netronome.com> References: <20201117171347.GA27231@embeddedor> <20201117200646.GA10136@netronome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 17 Nov 2020 21:06:47 +0100 Simon Horman wrote: > On Tue, Nov 17, 2020 at 11:13:47AM -0600, Gustavo A. R. Silva wrote: > > Fix the following unreachable code issue: > > > > drivers/net/ethernet/netronome/nfp/crypto/tls.c: In function 'nfp_net_tls_add': > > include/linux/compiler_attributes.h:208:41: warning: statement will never be executed [-Wswitch-unreachable] > > 208 | # define fallthrough __attribute__((__fallthrough__)) > > | ^~~~~~~~~~~~~ > > drivers/net/ethernet/netronome/nfp/crypto/tls.c:299:3: note: in expansion of macro 'fallthrough' > > 299 | fallthrough; > > | ^~~~~~~~~~~ > > > > Reported-by: kernel test robot > > Signed-off-by: Gustavo A. R. Silva > > Reviewed-by: Simon Horman Applied, thanks!