* [PATCH] Documentation: kgdb: Fix a typo
@ 2020-11-16 9:42 Tiezhu Yang
2020-11-16 9:47 ` Daniel Thompson
2020-11-18 20:48 ` Jonathan Corbet
0 siblings, 2 replies; 3+ messages in thread
From: Tiezhu Yang @ 2020-11-16 9:42 UTC (permalink / raw)
To: Jason Wessel, Daniel Thompson, Douglas Anderson, Jonathan Corbet
Cc: kgdb-bugreport, linux-doc, linux-kernel, Xuefeng Li, Sergei Shtylyov
"to into" -> "into"
Reported-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
Documentation/dev-tools/kgdb.rst | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
index 77b688e..4345624 100644
--- a/Documentation/dev-tools/kgdb.rst
+++ b/Documentation/dev-tools/kgdb.rst
@@ -63,10 +63,9 @@ will want to turn on ``CONFIG_DEBUG_INFO`` which is called
It is advised, but not required, that you turn on the
``CONFIG_FRAME_POINTER`` kernel option which is called :menuselection:`Compile
the kernel with frame pointers` in the config menu. This option inserts code
-to into the compiled executable which saves the frame information in
-registers or on the stack at different points which allows a debugger
-such as gdb to more accurately construct stack back traces while
-debugging the kernel.
+into the compiled executable which saves the frame information in registers
+or on the stack at different points which allows a debugger such as gdb to
+more accurately construct stack back traces while debugging the kernel.
If the architecture that you are using supports the kernel option
``CONFIG_STRICT_KERNEL_RWX``, you should consider turning it off. This
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: kgdb: Fix a typo
2020-11-16 9:42 [PATCH] Documentation: kgdb: Fix a typo Tiezhu Yang
@ 2020-11-16 9:47 ` Daniel Thompson
2020-11-18 20:48 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2020-11-16 9:47 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Jason Wessel, Douglas Anderson, Jonathan Corbet, kgdb-bugreport,
linux-doc, linux-kernel, Xuefeng Li, Sergei Shtylyov
On Mon, Nov 16, 2020 at 05:42:47PM +0800, Tiezhu Yang wrote:
> "to into" -> "into"
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> Documentation/dev-tools/kgdb.rst | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index 77b688e..4345624 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -63,10 +63,9 @@ will want to turn on ``CONFIG_DEBUG_INFO`` which is called
> It is advised, but not required, that you turn on the
> ``CONFIG_FRAME_POINTER`` kernel option which is called :menuselection:`Compile
> the kernel with frame pointers` in the config menu. This option inserts code
> -to into the compiled executable which saves the frame information in
> -registers or on the stack at different points which allows a debugger
> -such as gdb to more accurately construct stack back traces while
> -debugging the kernel.
> +into the compiled executable which saves the frame information in registers
> +or on the stack at different points which allows a debugger such as gdb to
> +more accurately construct stack back traces while debugging the kernel.
>
> If the architecture that you are using supports the kernel option
> ``CONFIG_STRICT_KERNEL_RWX``, you should consider turning it off. This
> --
> 2.1.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Documentation: kgdb: Fix a typo
2020-11-16 9:42 [PATCH] Documentation: kgdb: Fix a typo Tiezhu Yang
2020-11-16 9:47 ` Daniel Thompson
@ 2020-11-18 20:48 ` Jonathan Corbet
1 sibling, 0 replies; 3+ messages in thread
From: Jonathan Corbet @ 2020-11-18 20:48 UTC (permalink / raw)
To: Tiezhu Yang
Cc: Jason Wessel, Daniel Thompson, Douglas Anderson, kgdb-bugreport,
linux-doc, linux-kernel, Xuefeng Li, Sergei Shtylyov
On Mon, 16 Nov 2020 17:42:47 +0800
Tiezhu Yang <yangtiezhu@loongson.cn> wrote:
> "to into" -> "into"
>
> Reported-by: Sergei Shtylyov <sergei.shtylyov@gmail.com>
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> ---
> Documentation/dev-tools/kgdb.rst | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/dev-tools/kgdb.rst b/Documentation/dev-tools/kgdb.rst
> index 77b688e..4345624 100644
> --- a/Documentation/dev-tools/kgdb.rst
> +++ b/Documentation/dev-tools/kgdb.rst
> @@ -63,10 +63,9 @@ will want to turn on ``CONFIG_DEBUG_INFO`` which is called
> It is advised, but not required, that you turn on the
> ``CONFIG_FRAME_POINTER`` kernel option which is called :menuselection:`Compile
> the kernel with frame pointers` in the config menu. This option inserts code
> -to into the compiled executable which saves the frame information in
> -registers or on the stack at different points which allows a debugger
> -such as gdb to more accurately construct stack back traces while
> -debugging the kernel.
> +into the compiled executable which saves the frame information in registers
> +or on the stack at different points which allows a debugger such as gdb to
> +more accurately construct stack back traces while debugging the kernel.
Applied.
In the future, though, please avoid refilling paragraphs when you make a
change like this; it makes it much harder to see what has actually changed.
Thanks,
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-11-18 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-16 9:42 [PATCH] Documentation: kgdb: Fix a typo Tiezhu Yang
2020-11-16 9:47 ` Daniel Thompson
2020-11-18 20:48 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).