From: Maxime Ripard <maxime@cerno.tech>
To: Wilken Gottwalt <wilken.gottwalt@posteo.net>
Cc: linux-kernel@vger.kernel.org, Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Baolin Wang <baolin.wang7@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support
Date: Wed, 18 Nov 2020 16:37:33 +0100 [thread overview]
Message-ID: <20201118153733.jgiokn6jkwu6rv6c@gilmour.lan> (raw)
In-Reply-To: <149526a0ba8d18ebb68baa24e95d946ede90b4c0.1605693132.git.wilken.gottwalt@posteo.net>
[-- Attachment #1: Type: text/plain, Size: 809 bytes --]
Hi Wilken,
On Wed, Nov 18, 2020 at 11:02:40AM +0100, Wilken Gottwalt wrote:
> Adds the sunxi_hwspinlock driver and updates makefiles/maintainers.
>
> Signed-off-by: Wilken Gottwalt <wilken.gottwalt@posteo.net>
A more descriptive commit log would be welcome here, for example
containing on which SoC this driver can be used, and on which it was
tested.
This is the third attempt at that driver, and you can find the previous
versions here:
https://patchwork.kernel.org/project/linux-arm-kernel/cover/20200210170143.20007-1-nborisov@suse.com/
https://lore.kernel.org/patchwork/patch/706512/
Most of the comments on those series still apply to yours.
Most importantly, this hwspinlock is used to synchronize the ARM cores
and the ARISC. How did you test this driver?
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2020-11-18 15:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 10:01 [PATCH 0/2] hwspinlock: add sunxi hardware spinlock support Wilken Gottwalt
2020-11-18 10:01 ` [PATCH 1/2] dt-bindings: hwlock: sunxi: add sunxi_hwspinlock documentation Wilken Gottwalt
2020-11-18 10:02 ` [PATCH 2/2] hwspinlock: add sunxi hardware spinlock support Wilken Gottwalt
2020-11-18 15:37 ` Maxime Ripard [this message]
2020-11-18 19:36 ` Wilken Gottwalt
2020-11-19 7:15 ` Maxime Ripard
2020-11-19 10:13 ` Wilken Gottwalt
2020-11-20 16:42 ` Maxime Ripard
2020-11-21 12:22 ` fuyao
2020-11-21 16:44 ` Maxime Ripard
2020-11-23 18:32 ` Wilken Gottwalt
2020-11-24 3:35 ` Samuel Holland
2020-11-24 14:28 ` Maxime Ripard
2020-11-26 13:10 ` Wilken Gottwalt
2020-11-22 5:19 ` Bjorn Andersson
2020-11-23 18:17 ` Wilken Gottwalt
2020-11-24 14:54 ` Bjorn Andersson
2020-11-26 13:31 ` Wilken Gottwalt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118153733.jgiokn6jkwu6rv6c@gilmour.lan \
--to=maxime@cerno.tech \
--cc=baolin.wang7@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=wilken.gottwalt@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).