From: Vinod Koul <vkoul@kernel.org>
To: Jonathan McDowell <noodles@earth.li>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Thomas Pedersen <twp@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: Re: [PATCH v5] dmaengine: qcom: Add ADM driver
Date: Wed, 18 Nov 2020 21:20:38 +0530 [thread overview]
Message-ID: <20201118155038.GU50232@vkoul-mobl> (raw)
In-Reply-To: <20201114140233.GM32650@earth.li>
On 14-11-20, 14:02, Jonathan McDowell wrote:
> Add the DMA engine driver for the QCOM Application Data Mover (ADM) DMA
> controller found in the MSM8x60 and IPQ/APQ8064 platforms.
>
> The ADM supports both memory to memory transactions and memory
> to/from peripheral device transactions. The controller also provides
> flow control capabilities for transactions to/from peripheral devices.
>
> The initial release of this driver supports slave transfers to/from
> peripherals and also incorporates CRCI (client rate control interface)
> flow control.
>
> The hardware only supports a 32 bit physical address, so specifying
> !PHYS_ADDR_T_64BIT gives maximum COMPILE_TEST coverage without having to
> spend effort on kludging things in the code that will never actually be
> needed on real hardware.
Applied, thanks
My build scripts emit the warnings below, please fix them up with the
follow up patch. You can get this with W=1
drivers/dma/qcom/qcom_adm.c:180: warning: Function parameter or member 'chan' not described in 'adm_free_chan'
drivers/dma/qcom/qcom_adm.c:190: warning: Function parameter or member 'burst' not described in 'adm_get_blksize'
drivers/dma/qcom/qcom_adm.c:466: warning: Function parameter or member 'chan' not described in 'adm_terminate_all'
drivers/dma/qcom/qcom_adm.c:466: warning: Excess function parameter 'achan' description in 'adm_terminate_all'
drivers/dma/qcom/qcom_adm.c:503: warning: Function parameter or member 'achan' not described in 'adm_start_dma'
--
~Vinod
prev parent reply other threads:[~2020-11-18 15:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 6:43 [PATCH] dmaengine: qcom: Add ADM driver Jonathan McDowell
2020-09-18 11:34 ` Vinod Koul
2020-09-18 18:39 ` Jonathan McDowell
2020-09-19 18:57 ` [PATCH v2] " Jonathan McDowell
2020-09-20 18:12 ` [PATCH v3] " Jonathan McDowell
2020-09-21 8:41 ` Philipp Zabel
2020-09-23 19:40 ` [PATCH v4] " Jonathan McDowell
2020-10-25 18:11 ` Jonathan McDowell
2020-10-28 16:04 ` Vinod Koul
2020-11-09 11:41 ` Vinod Koul
2020-11-09 19:04 ` Jonathan McDowell
2020-11-10 4:54 ` Vinod Koul
2020-11-14 14:02 ` [PATCH v5] " Jonathan McDowell
2020-11-18 15:50 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118155038.GU50232@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
--cc=p.zabel@pengutronix.de \
--cc=twp@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).