From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D1EC3E8C5 for ; Wed, 18 Nov 2020 17:58:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDFCF2463B for ; Wed, 18 Nov 2020 17:58:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bRZdlXx5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726281AbgKRR6S (ORCPT ); Wed, 18 Nov 2020 12:58:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbgKRR6S (ORCPT ); Wed, 18 Nov 2020 12:58:18 -0500 Received: from mail-oo1-xc41.google.com (mail-oo1-xc41.google.com [IPv6:2607:f8b0:4864:20::c41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67AF2C0613D6 for ; Wed, 18 Nov 2020 09:58:18 -0800 (PST) Received: by mail-oo1-xc41.google.com with SMTP id i13so642648oou.11 for ; Wed, 18 Nov 2020 09:58:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ype8c0rhDFgZ75ftBGay9s36wJiNcNYG5bOFvh9dHc8=; b=bRZdlXx5hBOzDd132mrm/QxucR8+0v+UBvSaXStZNTg6EWimeL6IFua12EeoiEwndp L8yTZWpP5ydWcqCsOm8BpWwIUoL/ZympVQQXXgGLW0prlhycx99+BVzZq5dWveiRlIxk SFoZZ7+b1UdgOD1z0o/6sw5i+0RQVYLcQyjvcYinlEzbyC22gYGmD6F8xU4gKxwvo+tl b6sdSPXoetLaFlXC0Ipsk0Upi8F2ghO4w6OAQwzvHE7bcxHz6qlwTqQkGCMCUWtrKCf6 vYMPZfVjIYJV+ZYXYpDVySRZ6lP96MLigaT7rgHQNMyC9+VQyT1SC0Jo+MR3PQNCtLiM qUTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ype8c0rhDFgZ75ftBGay9s36wJiNcNYG5bOFvh9dHc8=; b=IAbm92vlkVoIg3l5XkgNdnIlUShZ3pIM6VtM6+hOxgzGCcRSF8ygxMY4UbOCEmLack lI8c5kEh7pQs2eHsIARaFFkDJGw8xfVrVzdq15DPs9yOIaEh2ecR4GS/PzUiQ00YA1mT /Y2SMMW9VvJ5Q9MeoCivc7z7KtB3GA4dPMFHHTihIzpzM5+MzehF0jxJQ6UKl392W0kJ m1Rr7Pkl5Bj9YWha4NMRZF49pCDs/0f6WmgLN6EJzbGXh+gJiEmx2L+zHMNemf2SANJA IIMwHBhOCHvimKDznvXYOZhntoCbxGETftpqddk15uoWmTPJwGVCZ+Oo0QgwM0umT4n7 NkHA== X-Gm-Message-State: AOAM530ng4RXrDLwYMjhzRL+S6qL04SDK/agJB/Q1rmaznvGne4FR0YY eD976XdHhQKQZ/73Z7g3KW2cXQ== X-Google-Smtp-Source: ABdhPJyPQg27yiEWaOCyMrK+70i4GG+36VSaQ/+Nl4DzQ6kXvkBpetR7ZAG5EVjcqS0Yg1YaJv/ZbA== X-Received: by 2002:a4a:c4c7:: with SMTP id g7mr7122549ooq.50.1605722297630; Wed, 18 Nov 2020 09:58:17 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id c6sm58938oif.48.2020.11.18.09.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Nov 2020 09:58:16 -0800 (PST) Date: Wed, 18 Nov 2020 11:58:15 -0600 From: Bjorn Andersson To: Sibi Sankar Cc: ohad@wizery.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, agross@kernel.org, evgreen@chromium.org Subject: Re: [PATCH 1/2] remoteproc: qcom_q6v5_mss: Replace ioremap with memremap Message-ID: <20201118175815.GE9177@builder.lan> References: <1604473422-29639-1-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1604473422-29639-1-git-send-email-sibis@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 04 Nov 01:03 CST 2020, Sibi Sankar wrote: > Fix the sparse warnings reported by the kernel test bot by replacing > ioremap calls with memremap. > > Reported-by: kernel test robot Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Sibi Sankar > --- > > I'll send out the patches to convert ioremap to memremap on other > qc remoteproc drivers once I get a chance to test them. > > drivers/remoteproc/qcom_q6v5_mss.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c > index 9a473cfef758..2c866b6da23c 100644 > --- a/drivers/remoteproc/qcom_q6v5_mss.c > +++ b/drivers/remoteproc/qcom_q6v5_mss.c > @@ -1194,7 +1194,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc) > goto release_firmware; > } > > - ptr = ioremap_wc(qproc->mpss_phys + offset, phdr->p_memsz); > + ptr = memremap(qproc->mpss_phys + offset, phdr->p_memsz, MEMREMAP_WC); > if (!ptr) { > dev_err(qproc->dev, > "unable to map memory region: %pa+%zx-%x\n", > @@ -1209,7 +1209,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc) > "failed to load segment %d from truncated file %s\n", > i, fw_name); > ret = -EINVAL; > - iounmap(ptr); > + memunmap(ptr); > goto release_firmware; > } > > @@ -1221,7 +1221,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc) > ptr, phdr->p_filesz); > if (ret) { > dev_err(qproc->dev, "failed to load %s\n", fw_name); > - iounmap(ptr); > + memunmap(ptr); > goto release_firmware; > } > > @@ -1232,7 +1232,7 @@ static int q6v5_mpss_load(struct q6v5 *qproc) > memset(ptr + phdr->p_filesz, 0, > phdr->p_memsz - phdr->p_filesz); > } > - iounmap(ptr); > + memunmap(ptr); > size += phdr->p_memsz; > > code_length = readl(qproc->rmb_base + RMB_PMI_CODE_LENGTH_REG); > @@ -1299,11 +1299,11 @@ static void qcom_q6v5_dump_segment(struct rproc *rproc, > } > > if (!ret) > - ptr = ioremap_wc(qproc->mpss_phys + offset + cp_offset, size); > + ptr = memremap(qproc->mpss_phys + offset + cp_offset, size, MEMREMAP_WC); > > if (ptr) { > memcpy(dest, ptr, size); > - iounmap(ptr); > + memunmap(ptr); > } else { > memset(dest, 0xff, size); > } > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >