From: Roman Gushchin <guro@fb.com>
To: Shakeel Butt <shakeelb@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] memcg, kmem: further deprecate kmem.limit_in_bytes
Date: Wed, 18 Nov 2020 11:46:20 -0800 [thread overview]
Message-ID: <20201118194620.GD186396@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <20201118175726.2453120-1-shakeelb@google.com>
On Wed, Nov 18, 2020 at 09:57:26AM -0800, Shakeel Butt wrote:
> The deprecation process of kmem.limit_in_bytes started with the commit
> 0158115f702 ("memcg, kmem: deprecate kmem.limit_in_bytes") which also
> explains in detail the motivation behind the deprecation. To summarize,
> it is the unexpected behavior on hitting the kmem limit. This patch
> moves the deprecation process to the next stage by disallowing to set
> the kmem limit. In future we might just remove the kmem.limit_in_bytes
> file completely.
>
> Signed-off-by: Shakeel Butt <shakeelb@google.com>
The first stage was done over a year ago, so if there were no complains
it feels like it's a good time to move forward.
Acked-by: Roman Gushchin <guro@fb.com>
The only question I have is if it's better to return -EINVAL or -ENOTSUPP.
The latter option could be more convenient for userspace, because it will
be clear that the kernel is not supporting the functionality, rather than
the passed value is incorrect (e.g. if the value is read from a config, provided
by a user). I'm not sure though, just an idea.
Thanks!
next prev parent reply other threads:[~2020-11-18 19:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 17:57 [PATCH] memcg, kmem: further deprecate kmem.limit_in_bytes Shakeel Butt
2020-11-18 19:46 ` Roman Gushchin [this message]
2020-11-18 19:54 ` Shakeel Butt
2020-11-18 19:58 ` Michal Hocko
2020-11-18 20:07 ` Shakeel Butt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118194620.GD186396@carbon.dhcp.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).