From: Ludovic Desroches <ludovic.desroches@microchip.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: <cristian.birsan@microchip.com>, <nicolas.ferre@microchip.com>,
<robh+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linus.walleij@linaro.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host
Date: Wed, 18 Nov 2020 22:10:36 +0100 [thread overview]
Message-ID: <20201118210530.2liwy4sywichojry@sekiro> (raw)
In-Reply-To: <20201118152652.GA11581@piout.net>
On Wed, Nov 18, 2020 at 04:26:52PM +0100, Alexandre Belloni wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Hello,
>
> On 18/11/2020 16:03:36+0100, Ludovic Desroches wrote:
> > At first glance, there is no trivial way to register the pin range in the
> > pinctrl-at91 driver. There is one driver for the pinctrl and one for the gpio.
> > I am open to suggestions to fix it in the pinctrl-at91 driver as well if there
> > is an elegant way (I have some in mind, but there are not) without having to
> > refactor the driver.
> >
>
> But shouldn't that driver be refactored at some point anyway? I know you
> are moving away with new SoCs but it causes real issues. For example,
> gpio hogs are not working, this is impacting some of your customers.
>
I agree, maintainance of this driver is difficult because of its design.
Unfortunately, I doubt being able to hadnle a refactoring of this driver in a
near future.
> The other thing is the weird probe order preventing a nice cleanup of
> the platform code.
True. IMO, having gpio controlers probed before pinctrl is one of the reason
which prevents a trivial fix.
Regards
Ludovic
>
>
> --
> Alexandre Belloni, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
next prev parent reply other threads:[~2020-11-18 21:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 12:00 [PATCH 0/3] ARM: dts: at91: add pincontrol node for USB Host cristian.birsan
2020-11-18 12:00 ` [PATCH 1/3] ARM: dts: sam9x60: add pincontrol " cristian.birsan
2020-11-18 12:00 ` [PATCH 2/3] ARM: dts: at91: sama5d4_xplained: " cristian.birsan
2020-11-18 12:00 ` [PATCH 3/3] ARM: dts: at91: sama5d3_xplained: " cristian.birsan
2020-11-18 15:03 ` [PATCH 0/3] ARM: dts: at91: add pincontrol node " Ludovic Desroches
2020-11-18 15:26 ` Alexandre Belloni
2020-11-18 21:10 ` Ludovic Desroches [this message]
2020-11-24 11:24 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118210530.2liwy4sywichojry@sekiro \
--to=ludovic.desroches@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=cristian.birsan@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).