From: Rob Herring <robh@kernel.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>, Nishanth Menon <nm@ti.com>,
Tom Joseph <tjoseph@cadence.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-j721e-main: Remove "syscon" nodes added for pcieX_ctrl
Date: Wed, 18 Nov 2020 15:14:26 -0600 [thread overview]
Message-ID: <20201118211426.GB1815279@bogus> (raw)
In-Reply-To: <20201116173141.31873-4-kishon@ti.com>
On Mon, Nov 16, 2020 at 11:01:41PM +0530, Kishon Vijay Abraham I wrote:
> Remove "syscon" nodes added for pcieX_ctrl and have the PCIe node
> point to the parent with an offset argument.
This should say breaks compatibility, but that fine because ????. It
only landed in 5.9 and a new platform I suppose.
>
> Link: http://lore.kernel.org/r/CAL_JsqKiUcO76bo1GoepWM1TusJWoty_BRy2hFSgtEVMqtrvvQ@mail.gmail.com
Should have a Fixes tag IMO.
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 48 ++++-------------------
> 1 file changed, 8 insertions(+), 40 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 620e69e42974..23a0024dda79 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -28,38 +28,6 @@
> #size-cells = <1>;
> ranges = <0x0 0x0 0x00100000 0x1c000>;
>
> - pcie0_ctrl: syscon@4070 {
> - compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
> - reg = <0x00004070 0x4>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0x4070 0x4070 0x4>;
> - };
> -
> - pcie1_ctrl: syscon@4074 {
> - compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
> - reg = <0x00004074 0x4>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0x4074 0x4074 0x4>;
> - };
> -
> - pcie2_ctrl: syscon@4078 {
> - compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
> - reg = <0x00004078 0x4>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0x4078 0x4078 0x4>;
> - };
> -
> - pcie3_ctrl: syscon@407c {
> - compatible = "ti,j721e-system-controller", "syscon", "simple-mfd";
> - reg = <0x0000407c 0x4>;
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges = <0x407c 0x407c 0x4>;
> - };
> -
> serdes_ln_ctrl: mux@4080 {
> compatible = "mmio-mux";
> reg = <0x00004080 0x50>;
> @@ -619,7 +587,7 @@
> interrupt-names = "link_state";
> interrupts = <GIC_SPI 318 IRQ_TYPE_EDGE_RISING>;
> device_type = "pci";
> - ti,syscon-pcie-ctrl = <&pcie0_ctrl>;
> + ti,syscon-pcie-ctrl = <&scm_conf 0x4070>;
> max-link-speed = <3>;
> num-lanes = <2>;
> power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>;
> @@ -646,7 +614,7 @@
> reg-names = "intd_cfg", "user_cfg", "reg", "mem";
> interrupt-names = "link_state";
> interrupts = <GIC_SPI 318 IRQ_TYPE_EDGE_RISING>;
> - ti,syscon-pcie-ctrl = <&pcie0_ctrl>;
> + ti,syscon-pcie-ctrl = <&scm_conf 0x4070>;
> max-link-speed = <3>;
> num-lanes = <2>;
> power-domains = <&k3_pds 239 TI_SCI_PD_EXCLUSIVE>;
> @@ -668,7 +636,7 @@
> interrupt-names = "link_state";
> interrupts = <GIC_SPI 330 IRQ_TYPE_EDGE_RISING>;
> device_type = "pci";
> - ti,syscon-pcie-ctrl = <&pcie1_ctrl>;
> + ti,syscon-pcie-ctrl = <&scm_conf 0x4074>;
> max-link-speed = <3>;
> num-lanes = <2>;
> power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
> @@ -695,7 +663,7 @@
> reg-names = "intd_cfg", "user_cfg", "reg", "mem";
> interrupt-names = "link_state";
> interrupts = <GIC_SPI 330 IRQ_TYPE_EDGE_RISING>;
> - ti,syscon-pcie-ctrl = <&pcie1_ctrl>;
> + ti,syscon-pcie-ctrl = <&scm_conf 0x4074>;
> max-link-speed = <3>;
> num-lanes = <2>;
> power-domains = <&k3_pds 240 TI_SCI_PD_EXCLUSIVE>;
> @@ -717,7 +685,7 @@
> interrupt-names = "link_state";
> interrupts = <GIC_SPI 342 IRQ_TYPE_EDGE_RISING>;
> device_type = "pci";
> - ti,syscon-pcie-ctrl = <&pcie2_ctrl>;
> + ti,syscon-pcie-ctrl = <&scm_conf 0x4078>;
> max-link-speed = <3>;
> num-lanes = <2>;
> power-domains = <&k3_pds 241 TI_SCI_PD_EXCLUSIVE>;
> @@ -744,7 +712,7 @@
> reg-names = "intd_cfg", "user_cfg", "reg", "mem";
> interrupt-names = "link_state";
> interrupts = <GIC_SPI 342 IRQ_TYPE_EDGE_RISING>;
> - ti,syscon-pcie-ctrl = <&pcie2_ctrl>;
> + ti,syscon-pcie-ctrl = <&scm_conf 0x4078>;
> max-link-speed = <3>;
> num-lanes = <2>;
> power-domains = <&k3_pds 241 TI_SCI_PD_EXCLUSIVE>;
> @@ -766,7 +734,7 @@
> interrupt-names = "link_state";
> interrupts = <GIC_SPI 354 IRQ_TYPE_EDGE_RISING>;
> device_type = "pci";
> - ti,syscon-pcie-ctrl = <&pcie3_ctrl>;
> + ti,syscon-pcie-ctrl = <&scm_conf 0x407c>;
> max-link-speed = <3>;
> num-lanes = <2>;
> power-domains = <&k3_pds 242 TI_SCI_PD_EXCLUSIVE>;
> @@ -793,7 +761,7 @@
> reg-names = "intd_cfg", "user_cfg", "reg", "mem";
> interrupt-names = "link_state";
> interrupts = <GIC_SPI 354 IRQ_TYPE_EDGE_RISING>;
> - ti,syscon-pcie-ctrl = <&pcie3_ctrl>;
> + ti,syscon-pcie-ctrl = <&scm_conf 0x407c>;
> max-link-speed = <3>;
> num-lanes = <2>;
> power-domains = <&k3_pds 242 TI_SCI_PD_EXCLUSIVE>;
> --
> 2.17.1
>
prev parent reply other threads:[~2020-11-18 21:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:31 [PATCH 0/3] PCI: J721E: Fix Broken DT w.r.t SYSCON DT Kishon Vijay Abraham I
2020-11-16 17:31 ` [PATCH 1/3] dt-bindings: pci: ti,j721e: Fix "ti,syscon-pcie-ctrl" to take argument Kishon Vijay Abraham I
2020-11-18 21:11 ` Rob Herring
2020-11-20 5:09 ` Kishon Vijay Abraham I
2020-11-26 12:53 ` Kishon Vijay Abraham I
2020-11-30 16:12 ` Rob Herring
2020-11-19 13:41 ` [PATCH 1/3] dt-bindings: pci: ti, j721e: Fix "ti, syscon-pcie-ctrl" " Rob Herring
2020-11-16 17:31 ` [PATCH 2/3] PCI: j721e: Get offset within "syscon" from "ti,syscon-pcie-ctrl" phandle arg Kishon Vijay Abraham I
2020-11-16 17:31 ` [PATCH 3/3] arm64: dts: ti: k3-j721e-main: Remove "syscon" nodes added for pcieX_ctrl Kishon Vijay Abraham I
2020-11-18 21:14 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201118211426.GB1815279@bogus \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).