From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 098C5C6379F for ; Wed, 18 Nov 2020 21:37:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCA38246CA for ; Wed, 18 Nov 2020 21:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727337AbgKRVhX (ORCPT ); Wed, 18 Nov 2020 16:37:23 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:60534 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727270AbgKRVhP (ORCPT ); Wed, 18 Nov 2020 16:37:15 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id CC16F1C0B87; Wed, 18 Nov 2020 22:37:12 +0100 (CET) Date: Wed, 18 Nov 2020 22:37:12 +0100 From: Pavel Machek To: Gene Chen Cc: jacek.anaszewski@gmail.com, robh+dt@kernel.org, matthias.bgg@gmail.com, dmurphy@ti.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, gene_chen@richtek.com, Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Subject: Re: [PATCH v7 2/5] dt-bindings: leds: Add LED_COLOR_ID_MOONLIGHT definitions Message-ID: <20201118213712.GA22371@amd> References: <1605696462-391-1-git-send-email-gene.chen.richtek@gmail.com> <1605696462-391-3-git-send-email-gene.chen.richtek@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2oS5YaxWCcQjTEyO" Content-Disposition: inline In-Reply-To: <1605696462-391-3-git-send-email-gene.chen.richtek@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > From: Gene Chen >=20 > Add LED_COLOR_ID_MOONLIGHT definitions Why is moonlight a color? Camera flashes are usually white, no? At least it needs a comment... Best regards, Pavel =09 > Signed-off-by: Gene Chen > --- > include/dt-bindings/leds/common.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds= /common.h > index 52b619d..1409e9a 100644 > --- a/include/dt-bindings/leds/common.h > +++ b/include/dt-bindings/leds/common.h > @@ -33,7 +33,8 @@ > #define LED_COLOR_ID_MULTI 8 /* For multicolor LEDs */ > #define LED_COLOR_ID_RGB 9 /* For multicolor LEDs that can do arbitrary = color, > so this would include RGBW and similar */ > -#define LED_COLOR_ID_MAX 10 > +#define LED_COLOR_ID_MOONLIGHT 10 > +#define LED_COLOR_ID_MAX 11 > =20 > /* Standard LED functions */ > /* Keyboard LEDs, usually it would be input4::capslock etc. */ --=20 http://www.livejournal.com/~pavelmachek --2oS5YaxWCcQjTEyO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl+1lAgACgkQMOfwapXb+vL26wCeLtwDg4oxx0PYQmJyevNM3Ckd 2IIAmQGlhDWSRiDQqYO8KZnDIql3iy6g =k8BQ -----END PGP SIGNATURE----- --2oS5YaxWCcQjTEyO--