From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Chen Yu <yu.c.chen@intel.com>, Chen Yu <yu.chen.surf@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v4 2/4] tools/bootconfig: Fix to check the write failure correctly
Date: Thu, 19 Nov 2020 08:59:02 -0500 [thread overview]
Message-ID: <20201119085902.05df502b@gandalf.local.home> (raw)
In-Reply-To: <20201119104109.8ab69359ce81d74c7d2d9c3f@kernel.org>
On Thu, 19 Nov 2020 10:41:09 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > If the first write fails (doesn't modify the initrd), and then this fails,
> > you will show a message of: "may be corrupted. Recommend to rebuild", when
> > that would not be the case. Should a test of the size be done again, to see
> > if it is already the same?
>
> Please see the above 2 write error check. You can find
>
> if (ret < 0)
> goto out;
>
> only in the first check. (I know, it might a bit misleadable)
> So, the first write is failed with error message, it doesn't call rollback.
Ah right, I missed check within the error check. I was only looking at the
first error and the goto at the end.
-- Steve
next prev parent reply other threads:[~2020-11-19 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 15:35 [PATCH v4 0/4] tools/bootconfig: Align the bootconfig applied initrd Masami Hiramatsu
2020-11-18 15:35 ` [PATCH v4 1/4] tools/bootconfig: Fix errno reference after printf() Masami Hiramatsu
2020-11-18 15:35 ` [PATCH v4 2/4] tools/bootconfig: Fix to check the write failure correctly Masami Hiramatsu
2020-11-18 16:04 ` Steven Rostedt
2020-11-19 1:41 ` Masami Hiramatsu
2020-11-19 13:59 ` Steven Rostedt [this message]
2020-11-19 5:42 ` Masami Hiramatsu
2020-11-18 15:35 ` [PATCH v4 3/4] tools/bootconfig: Align the bootconfig applied initrd image size to 4 Masami Hiramatsu
2020-11-18 16:22 ` Steven Rostedt
2020-11-19 2:32 ` Masami Hiramatsu
2020-11-18 15:35 ` [PATCH v4 4/4] docs: bootconfig: Update file format on initrd image Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119085902.05df502b@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=corbet@lwn.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=yu.c.chen@intel.com \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).