From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15715C64E7C for ; Thu, 19 Nov 2020 11:44:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6D062224E for ; Thu, 19 Nov 2020 11:44:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="u5YkmIui" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727617AbgKSLoC (ORCPT ); Thu, 19 Nov 2020 06:44:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727407AbgKSLnE (ORCPT ); Thu, 19 Nov 2020 06:43:04 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 491D4C061A54 for ; Thu, 19 Nov 2020 03:43:04 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id r17so6158369wrw.1 for ; Thu, 19 Nov 2020 03:43:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kj1XFCNYXRV/njfVjs4Ag/WpgjQdsavMbI7mVJToB1A=; b=u5YkmIui8TBX84E4s9zs9lIfaV4McIitjL2qgwQDyEUusXOmQ5iRJ7zufbqR/D270d E2KlJmesqjo8seQvnd/JWUEuGBFOz8Ysp/4LBlEBmyJbZXSDGda7u4aqFVeSjJ9xAdXM opxD6g4fzlpUPJqTmtWU5wShQdqr+gGDGRGJKQC0Gik1CHaUr2Hilorv6Zymb6L19JHU 4Z4dVL+QZFET2dgIaULQFif0NZbvPb6IFLi9Fh0UpucLlzMb6qC/jj2PhyJYoYISvZMM iqMtBiLFo+VzyRRMuSCcpYXJHAtrzR5Ie/z8/+iEL0GQXELlp7p9Z7/AO5a5U7AzJ+ui U8zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kj1XFCNYXRV/njfVjs4Ag/WpgjQdsavMbI7mVJToB1A=; b=gZ7YtQLp2g/l6o4BnC3R75Chm+5qfJmLiEiBUZR8A/cwG4XFcF1TcFF43fCOE+noNA H4fKrkxNoMydnexzHpV3gd4PGrKE0hV4G8zUaawC0hpt2qXtfvz7qn5kREbyoAkeMj99 9qIGx9AWiCqJSozLYhVGbTheKn4lllXcK3+gUKVe8p9redwRkn1DkpHKk118BNbz2Yx0 tA612fq825ZOEJ3lSkZexKcP7dJHJe0TULqg9Hj54h1pR9ESx8J/g7CqiMrw8GAr+Uqg s6a8b2ik7rfApI0ZhRG6hkixmESDQHdYdIamqnfr8AloXaJDbtviQYifleRdp2KkTUUD Lnmg== X-Gm-Message-State: AOAM531eNhFQejnm495hO41x6KiSuUwKrnVETdGYZvTmd7caPBR5XB7t gmtCnaDpfp1x0uPtwL7v5lPHvg== X-Google-Smtp-Source: ABdhPJymR6wIpmdhr2puj0GgaV9PCpn+UpYgKNv7hGqyrNRWRVBxnz7uhg25EYpNFI/bQZtuoCLd0g== X-Received: by 2002:adf:ce07:: with SMTP id p7mr10472174wrn.39.1605786182868; Thu, 19 Nov 2020 03:43:02 -0800 (PST) Received: from localhost.localdomain (lfbn-nic-1-190-206.w2-15.abo.wanadoo.fr. [2.15.39.206]) by smtp.gmail.com with ESMTPSA id u23sm9745178wmc.32.2020.11.19.03.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 03:43:02 -0800 (PST) From: Bartosz Golaszewski To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 54/59] rtc: fm3130: stop using deprecated RTC API Date: Thu, 19 Nov 2020 12:41:44 +0100 Message-Id: <20201119114149.4117-55-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201119114149.4117-1-brgl@bgdev.pl> References: <20201119114149.4117-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski devm_rtc_device_register() is deprecated. Use devm_rtc_allocate_device() and devm_rtc_register_device() pair instead. While at it: remove unnecessary goto label. Signed-off-by: Bartosz Golaszewski --- drivers/rtc/rtc-fm3130.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/rtc/rtc-fm3130.c b/drivers/rtc/rtc-fm3130.c index 677ec2da13d8..29e296f2faab 100644 --- a/drivers/rtc/rtc-fm3130.c +++ b/drivers/rtc/rtc-fm3130.c @@ -344,7 +344,6 @@ static int fm3130_probe(struct i2c_client *client, const struct i2c_device_id *id) { struct fm3130 *fm3130; - int err = -ENODEV; int tmp; struct i2c_adapter *adapter = client->adapter; @@ -390,8 +389,7 @@ static int fm3130_probe(struct i2c_client *client, tmp = i2c_transfer(adapter, fm3130->msg, 4); if (tmp != 4) { dev_dbg(&client->dev, "read error %d\n", tmp); - err = -EIO; - goto exit_free; + return -EIO; } fm3130->regs[FM3130_RTC_CONTROL] = @@ -501,17 +499,13 @@ static int fm3130_probe(struct i2c_client *client, /* We won't bail out here because we just got invalid data. Time setting from u-boot doesn't work anyway */ - fm3130->rtc = devm_rtc_device_register(&client->dev, client->name, - &fm3130_rtc_ops, THIS_MODULE); - if (IS_ERR(fm3130->rtc)) { - err = PTR_ERR(fm3130->rtc); - dev_err(&client->dev, - "unable to register the class device\n"); - goto exit_free; - } - return 0; -exit_free: - return err; + fm3130->rtc = devm_rtc_allocate_device(&client->dev); + if (IS_ERR(fm3130->rtc)) + return PTR_ERR(fm3130->rtc); + + fm3130->rtc->ops = &fm3130_rtc_ops; + + return devm_rtc_register_device(fm3130->rtc); } static struct i2c_driver fm3130_driver = { -- 2.29.1