From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61E64C2D0E4 for ; Thu, 19 Nov 2020 11:44:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0B462224E for ; Thu, 19 Nov 2020 11:44:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="ChK+v5V+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727556AbgKSLnw (ORCPT ); Thu, 19 Nov 2020 06:43:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727417AbgKSLnG (ORCPT ); Thu, 19 Nov 2020 06:43:06 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D354C061A56 for ; Thu, 19 Nov 2020 03:43:05 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id d12so6027662wrr.13 for ; Thu, 19 Nov 2020 03:43:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=exdIJW2r8sVksRfNex+pvgxCMn/tRZ4EbVh8qlTWnAE=; b=ChK+v5V+9wopuXs5xYhnhY+T9HTLx7TZP8I2l0ziIUvjeSMv4ncNnK1WMY6mcL6ipG ZXYthnLS1QAAnSsu2d2kXZBRIsqhG+FvfiaWKGHGvqKqynlio/hDSSuUMQkgL8G4UFTw dCynuQMXO+DnSieNuhKlWodspQyOFWci3gF/hlr5/cLsNjRHvg3PLWNmbkLeMvu07x2s /5vAHaOPmQ871YoqWbZA1GFZrF8k8jV6n6l1afWkO+J2u4RZDaRfJ7jxWTCrcsZ7wFhm +1BTvqGWttvGZF9qQ8pMz1ccHpsQCrSspcHRnzPjC3IyjxBfmTcq+t7mWiEyGvlyaR3v ifZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=exdIJW2r8sVksRfNex+pvgxCMn/tRZ4EbVh8qlTWnAE=; b=QuTRpT/Z+v8Utyi29LiZfcCnuzTuHJPSX5NA1PJTKrKkc/pLjd9D/sxu13Yq4F2bEl NqAzS668NK3SBc/18z5T8en4kxSYj8MpwoKA329dP0NJgG2/1K8a/pePGFBPtxlc7ETQ J2fcpGALBzCNoa28NiZA2e9tOetFRT8rnUzH70i46MtBTcRlfhukdZVQ/aCOTXCQIeSd AByXCL1kdXDcmLfdkbbu4wlzuvVccC2D93te2Ws+VHZztZ4dCO6dFk3F1OeFtfm3hJdR jJQ5FJq37shnqq0lsab4/b4x++1B1s/YIrv2wySaaxlZcFPzktuGcxKZJrl3JS8XiEDL ILRw== X-Gm-Message-State: AOAM532ktTGkJUnEPBHyo6edhh8hU2v+5oxZwWJhfzguZqnmAiTIsTsz GVLvqEUlgAUbxP3paEnLm+dWKw== X-Google-Smtp-Source: ABdhPJyw40WOMlJQ1M8qN73iJ4j6OTt1gen0BdltQbviT9Nc8iPhQR/lZkxcbmzHXUdbZoZym6NZlw== X-Received: by 2002:a5d:5146:: with SMTP id u6mr10287019wrt.66.1605786183894; Thu, 19 Nov 2020 03:43:03 -0800 (PST) Received: from localhost.localdomain (lfbn-nic-1-190-206.w2-15.abo.wanadoo.fr. [2.15.39.206]) by smtp.gmail.com with ESMTPSA id u23sm9745178wmc.32.2020.11.19.03.43.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 03:43:03 -0800 (PST) From: Bartosz Golaszewski To: Alessandro Zummo , Alexandre Belloni Cc: linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH 55/59] rtc: rtd119x: stop using deprecated RTC API Date: Thu, 19 Nov 2020 12:41:45 +0100 Message-Id: <20201119114149.4117-56-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201119114149.4117-1-brgl@bgdev.pl> References: <20201119114149.4117-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bartosz Golaszewski devm_rtc_device_register() is deprecated. Use devm_rtc_allocate_device() and devm_rtc_register_device() pair instead. Signed-off-by: Bartosz Golaszewski --- drivers/rtc/rtc-rtd119x.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-rtd119x.c b/drivers/rtc/rtc-rtd119x.c index bb98f2d574a5..547ab60adb3f 100644 --- a/drivers/rtc/rtc-rtd119x.c +++ b/drivers/rtc/rtc-rtd119x.c @@ -205,10 +205,17 @@ static int rtd119x_rtc_probe(struct platform_device *pdev) rtd119x_rtc_set_enabled(&pdev->dev, true); - data->rtcdev = devm_rtc_device_register(&pdev->dev, "rtc", - &rtd119x_rtc_ops, THIS_MODULE); + data->rtcdev = devm_rtc_allocate_device(&pdev->dev); if (IS_ERR(data->rtcdev)) { - dev_err(&pdev->dev, "failed to register rtc device"); + clk_disable_unprepare(data->clk); + clk_put(data->clk); + return PTR_ERR(data->rtcdev); + } + + data->rtcdev->ops = &rtd119x_rtc_ops; + + ret = devm_rtc_register_device(data->rtcdev); + if (ret) { clk_disable_unprepare(data->clk); clk_put(data->clk); return PTR_ERR(data->rtcdev); -- 2.29.1