linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
	linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: Re: [PATCH 00/59] rtc: remove all uses of devm_rtc_device_register()
Date: Thu, 19 Nov 2020 12:48:14 +0100	[thread overview]
Message-ID: <20201119114814.GA165507@piout.net> (raw)
In-Reply-To: <20201119114149.4117-1-brgl@bgdev.pl>

On 19/11/2020 12:40:50+0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> 
> So we now have two functions whose names are easy to confuse. I spent some
> time and simply converted all RTC drivers to using the preferred interface.
> 
> Obviously these have only been compile-tested. I hope I didn't broke too
> many drivers in the process. Most of the conversions was easy, sometime
> it required removing unnecessary goto labels. There's also one patch
> using a different devres helpers in here.
> 

I'm not going to apply this series as this is not how I wanted to
proceed (else this would have been done a while ago).

> Bartosz Golaszewski (59):
>   rtc: da9055: stop using deprecated RTC API
>   rtc: m41t94: stop using deprecated RTC API
>   rtc: ds1390: stop using deprecated RTC API
>   rtc: ds3232: stop using deprecated RTC API
>   rtc: rx6110: stop using deprecated RTC API
>   rtc: palmas: stop using deprecated RTC API
>   rtc: bq32k: stop using deprecated RTC API
>   rtc: m48t35: stop using deprecated RTC API
>   rtc: pcf50633: stop using deprecated RTC API
>   rtc: pcf8583: stop using deprecated RTC API
>   rtc: efi: stop using deprecated RTC API
>   rtc: pcf8523: stop using deprecated RTC API
>   rtc: stm32: stop using deprecated RTC API
>   rtc: max8925: stop using deprecated RTC API
>   rtc: max8907: stop using deprecated RTC API
>   rtc: pxa: stop using deprecated RTC API
>   rtc: hym8563: stop using deprecated RTC API
>   rtc: max6916: stop using deprecated RTC API
>   rtc: max8998: stop using deprecated RTC API
>   rtc: s5m: use devm_i2c_new_dummy_device()
>   rtc: s5m: stop using deprecated RTC API
>   rtc: moxart: stop using deprecated RTC API
>   rtc: hid: stop using deprecated RTC API
>   rtc: generic: stop using deprecated RTC API
>   rtc: lpc24xx: stop using deprecated RTC API
>   rtc: spear: stop using deprecated RTC API
>   rtc: max77686: stop using deprecated RTC API
>   rtc: ds1286: stop using deprecated RTC API
>   rtc: twl: stop using deprecated RTC API
>   rtc: s3c: stop using deprecated RTC API
>   rtc: mcp795: stop using deprecated RTC API
>   rtc: x1205: stop using deprecated RTC API
>   rtc: max6902: stop using deprecated RTC API
>   rtc: max6900: stop using deprecated RTC API
>   rtc: rx8025: stop using deprecated RTC API
>   rtc: asm9260: stop using deprecated RTC API
>   rtc: opal: stop using deprecated RTC API
>   rtc: rc5t583: stop using deprecated RTC API
>   rtc: wm8350: stop using deprecated RTC API
>   rtc: r7301: stop using deprecated RTC API
>   rtc: max8997: stop using deprecated RTC API
>   rtc: isl12022: stop using deprecated RTC API
>   rtc: tps80031: stop using deprecated RTC API
>   rtc: rs5c372: stop using deprecated RTC API
>   rtc: mt7622: stop using deprecated RTC API
>   rtc: ds1302: stop using deprecated RTC API
>   rtc: bq4802: stop using deprecated RTC API
>   rtc: rs5c313: stop using deprecated RTC API
>   rtc: em3027: stop using deprecated RTC API
>   rtc: v3020: stop using deprecated RTC API
>   rtc: ds1216: stop using deprecated RTC API
>   rtc: rx4581: stop using deprecated RTC API
>   rtc: m41t93: stop using deprecated RTC API
>   rtc: fm3130: stop using deprecated RTC API
>   rtc: rtd119x: stop using deprecated RTC API
>   rtc: msm6242: stop using deprecated RTC API
>   rtc: as3722: stop using deprecated RTC API
>   rtc: lp8788: stop using deprecated RTC API
>   rtc: remove devm_rtc_device_register()
> 
>  .../driver-api/driver-model/devres.rst        |  1 -
>  drivers/rtc/class.c                           | 36 -------------
>  drivers/rtc/rtc-as3722.c                      | 14 +++---
>  drivers/rtc/rtc-asm9260.c                     | 10 ++--
>  drivers/rtc/rtc-bq32k.c                       |  8 +--
>  drivers/rtc/rtc-bq4802.c                      | 30 +++++------
>  drivers/rtc/rtc-da9055.c                      | 19 +++----
>  drivers/rtc/rtc-ds1216.c                      |  8 +--
>  drivers/rtc/rtc-ds1286.c                      | 15 +++---
>  drivers/rtc/rtc-ds1302.c                      | 14 +++---
>  drivers/rtc/rtc-ds1390.c                      | 13 +++--
>  drivers/rtc/rtc-ds3232.c                      |  7 +--
>  drivers/rtc/rtc-efi.c                         |  6 +--
>  drivers/rtc/rtc-em3027.c                      |  6 +--
>  drivers/rtc/rtc-fm3130.c                      | 22 +++-----
>  drivers/rtc/rtc-generic.c                     |  6 +--
>  drivers/rtc/rtc-hid-sensor-time.c             | 21 ++++----
>  drivers/rtc/rtc-hym8563.c                     |  6 +--
>  drivers/rtc/rtc-isl12022.c                    | 11 ++--
>  drivers/rtc/rtc-lp8788.c                      | 11 ++--
>  drivers/rtc/rtc-lpc24xx.c                     | 10 ++--
>  drivers/rtc/rtc-m41t93.c                      |  6 +--
>  drivers/rtc/rtc-m41t94.c                      |  8 +--
>  drivers/rtc/rtc-m48t35.c                      | 10 ++--
>  drivers/rtc/rtc-max6900.c                     |  6 +--
>  drivers/rtc/rtc-max6902.c                     |  7 +--
>  drivers/rtc/rtc-max6916.c                     |  6 +--
>  drivers/rtc/rtc-max77686.c                    | 13 ++---
>  drivers/rtc/rtc-max8907.c                     | 14 +++---
>  drivers/rtc/rtc-max8925.c                     | 14 +++---
>  drivers/rtc/rtc-max8997.c                     | 21 ++++----
>  drivers/rtc/rtc-max8998.c                     | 13 ++---
>  drivers/rtc/rtc-mcp795.c                      |  7 +--
>  drivers/rtc/rtc-moxart.c                      | 12 ++---
>  drivers/rtc/rtc-msm6242.c                     |  7 +--
>  drivers/rtc/rtc-mt7622.c                      | 10 ++--
>  drivers/rtc/rtc-opal.c                        |  6 +--
>  drivers/rtc/rtc-palmas.c                      | 15 +++---
>  drivers/rtc/rtc-pcf50633.c                    |  8 +--
>  drivers/rtc/rtc-pcf8523.c                     |  7 +--
>  drivers/rtc/rtc-pcf8583.c                     | 10 ++--
>  drivers/rtc/rtc-pxa.c                         | 13 ++---
>  drivers/rtc/rtc-r7301.c                       |  7 +--
>  drivers/rtc/rtc-rc5t583.c                     | 14 +++---
>  drivers/rtc/rtc-rs5c313.c                     |  9 ++--
>  drivers/rtc/rtc-rs5c372.c                     | 36 +++++--------
>  drivers/rtc/rtc-rtd119x.c                     | 13 +++--
>  drivers/rtc/rtc-rx4581.c                      |  7 +--
>  drivers/rtc/rtc-rx6110.c                      | 12 ++---
>  drivers/rtc/rtc-rx8025.c                      | 11 ++--
>  drivers/rtc/rtc-s3c.c                         | 10 ++--
>  drivers/rtc/rtc-s5m.c                         | 50 ++++++++-----------
>  drivers/rtc/rtc-spear.c                       | 10 ++--
>  drivers/rtc/rtc-stm32.c                       | 18 ++++---
>  drivers/rtc/rtc-tps80031.c                    | 15 +++---
>  drivers/rtc/rtc-twl.c                         | 12 ++---
>  drivers/rtc/rtc-v3020.c                       |  9 +++-
>  drivers/rtc/rtc-wm8350.c                      | 14 +++---
>  drivers/rtc/rtc-x1205.c                       |  7 ++-
>  include/linux/rtc.h                           |  4 --
>  60 files changed, 346 insertions(+), 399 deletions(-)
> 
> -- 
> 2.29.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2020-11-19 11:49 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 11:40 [PATCH 00/59] rtc: remove all uses of devm_rtc_device_register() Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 01/59] rtc: da9055: stop using deprecated RTC API Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 02/59] rtc: m41t94: " Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 03/59] rtc: ds1390: " Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 04/59] rtc: ds3232: " Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 05/59] rtc: rx6110: " Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 06/59] rtc: palmas: " Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 07/59] rtc: bq32k: " Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 08/59] rtc: m48t35: " Bartosz Golaszewski
2020-11-19 11:40 ` [PATCH 09/59] rtc: pcf50633: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 10/59] rtc: pcf8583: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 11/59] rtc: efi: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 12/59] rtc: pcf8523: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 13/59] rtc: stm32: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 14/59] rtc: max8925: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 15/59] rtc: max8907: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 16/59] rtc: pxa: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 17/59] rtc: hym8563: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 18/59] rtc: max6916: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 19/59] rtc: max8998: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 20/59] rtc: s5m: use devm_i2c_new_dummy_device() Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 21/59] rtc: s5m: stop using deprecated RTC API Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 22/59] rtc: moxart: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 23/59] rtc: hid: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 24/59] rtc: generic: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 25/59] rtc: lpc24xx: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 26/59] rtc: spear: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 27/59] rtc: max77686: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 28/59] rtc: ds1286: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 29/59] rtc: twl: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 30/59] rtc: s3c: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 31/59] rtc: mcp795: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 32/59] rtc: x1205: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 33/59] rtc: max6902: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 34/59] rtc: max6900: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 35/59] rtc: rx8025: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 36/59] rtc: asm9260: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 37/59] rtc: opal: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 38/59] rtc: rc5t583: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 39/59] rtc: wm8350: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 40/59] rtc: r7301: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 41/59] rtc: max8997: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 42/59] rtc: isl12022: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 43/59] rtc: tps80031: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 44/59] rtc: rs5c372: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 45/59] rtc: mt7622: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 46/59] rtc: ds1302: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 47/59] rtc: bq4802: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 48/59] rtc: rs5c313: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 49/59] rtc: em3027: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 50/59] rtc: v3020: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 51/59] rtc: ds1216: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 52/59] rtc: rx4581: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 53/59] rtc: m41t93: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 54/59] rtc: fm3130: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 55/59] rtc: rtd119x: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 56/59] rtc: msm6242: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 57/59] rtc: as3722: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 58/59] rtc: lp8788: " Bartosz Golaszewski
2020-11-19 11:41 ` [PATCH 59/59] rtc: remove devm_rtc_device_register() Bartosz Golaszewski
2020-11-19 11:48 ` Alexandre Belloni [this message]
2020-11-19 12:15   ` [PATCH 00/59] rtc: remove all uses of devm_rtc_device_register() Bartosz Golaszewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119114814.GA165507@piout.net \
    --to=alexandre.belloni@bootlin.com \
    --cc=a.zummo@towertech.it \
    --cc=bgolaszewski@baylibre.com \
    --cc=brgl@bgdev.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).