Re: [PATCH v6 1/7] arm64: mm: Move reserve_crashkernel() into mem_init()

From: Catalin Marinas <catalin.marinas@arm.com>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com,
	Chen Zhou <chenzhou10@huawei.com>,
	robin.murphy@arm.com, linux-kernel@vger.kernel.org,
	jeremy.linton@arm.com, ardb@kernel.org,
	iommu@lists.linux-foundation.org, robh+dt@kernel.org,
	James Morse <james.morse@arm.com>,
	linux-rpi-kernel@lists.infradead.org, guohanjun@huawei.com,
	will@kernel.org, hch@lst.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 1/7] arm64: mm: Move reserve_crashkernel() into mem_init()
Date: Thu, 19 Nov 2020 17:25:24 +0000	[thread overview]
Message-ID: <20201119172523.GG4376@gaia> (raw)
In-Reply-To: <20201119171048.GD4376@gaia>

On Thu, Nov 19, 2020 at 05:10:49PM +0000, Catalin Marinas wrote:
> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
> index ed71b1c305d7..acdec0c67d3b 100644
> --- a/arch/arm64/mm/mmu.c
> +++ b/arch/arm64/mm/mmu.c
> @@ -469,6 +469,21 @@ void __init mark_linear_text_alias_ro(void)
>  			    PAGE_KERNEL_RO);
>  }
>  
> +static bool crash_mem_map __initdata;
> +
> +static int __init enable_crash_mem_map(char *arg)
> +{
> +	/*
> +	 * Proper parameter parsing is done by reserve_crashkernel(). We only
> +	 * need to know if the linear map has to avoid block mappings so that
> +	 * the crashkernel reservations can be unmapped later.
> +	 */
> +	crash_mem_map = false;

It should be set to true.

-- 
Catalin