From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9123C56201 for ; Thu, 19 Nov 2020 21:08:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D1C322255 for ; Thu, 19 Nov 2020 21:08:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726746AbgKSVIo (ORCPT ); Thu, 19 Nov 2020 16:08:44 -0500 Received: from relay12.mail.gandi.net ([217.70.178.232]:42085 "EHLO relay12.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726360AbgKSVIm (ORCPT ); Thu, 19 Nov 2020 16:08:42 -0500 Received: from localhost.localdomain (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay12.mail.gandi.net (Postfix) with ESMTPSA id 500C3200007; Thu, 19 Nov 2020 21:08:39 +0000 (UTC) From: Miquel Raynal To: Lee Jones Cc: Miquel Raynal , Dan Brown , Vignesh Raghavendra , Richard Weinberger , linux-kernel@vger.kernel.org, Boris Brezillon , linux-mtd@lists.infradead.org, Thomas Gleixner , David Woodhouse Subject: Re: [PATCH v3 15/23] mtd: rawnand: diskonchip: Marking unused variables as __always_unused Date: Thu, 19 Nov 2020 22:08:37 +0100 Message-Id: <20201119210837.25727-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201109182206.3037326-16-lee.jones@linaro.org> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: e4a81ebcc2557e9c1d7500d601983175981d34e1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-11-09 at 18:21:58 UTC, Lee Jones wrote: > 'dummy' is never checked (as per the nomenclature) and the use of > 'emtpymatch' is currently #if 0'ed out. We could also #if 0 the > declaration, but #ifery is pretty ugly, so I like to keep it to a > minimum. > > Fixes the following W=1 kernel build warning(s): > > drivers/mtd/nand/raw/diskonchip.c: In function ‘DoC_Delay’: > drivers/mtd/nand/raw/diskonchip.c:219:16: warning: variable ‘dummy’ set but not used [-Wunused-but-set-variable] > drivers/mtd/nand/raw/diskonchip.c: In function ‘doc200x_calculate_ecc’: > drivers/mtd/nand/raw/diskonchip.c:706:6: warning: variable ‘emptymatch’ set but not used [-Wunused-but-set-variable] > > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: Boris Brezillon > Cc: Dan Brown > Cc: David Woodhouse > Cc: Thomas Gleixner > Cc: linux-mtd@lists.infradead.org > Signed-off-by: Lee Jones Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel