* [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD
@ 2020-11-04 11:47 YouChing Lin
2020-11-04 17:44 ` Miquel Raynal
2020-11-19 21:11 ` Miquel Raynal
0 siblings, 2 replies; 5+ messages in thread
From: YouChing Lin @ 2020-11-04 11:47 UTC (permalink / raw)
To: miquel.raynal, richard, vigneshr
Cc: juliensu, gch981213, linux-mtd, linux-kernel, ycllin
The Macronix MX35LF2GE4AD / MX35LF4GE4AD are 3V, 2G / 4Gbit serial
SLC NAND flash device (with on-die ECC).
Validated by read, erase, read back, write, read back and nandtest
on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host
(drivers/spi/spi-mxic.c).
Signed-off-by: YouChing Lin <ycllin@mxic.com.tw>
---
drivers/mtd/nand/spi/macronix.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
index 8e801e4..4f7f954 100644
--- a/drivers/mtd/nand/spi/macronix.c
+++ b/drivers/mtd/nand/spi/macronix.c
@@ -119,6 +119,26 @@ static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,
&update_cache_variants),
SPINAND_HAS_QE_BIT,
SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)),
+ SPINAND_INFO("MX35LF2GE4AD",
+ SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x26),
+ NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 1, 1, 1),
+ NAND_ECCREQ(8, 512),
+ SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+ &write_cache_variants,
+ &update_cache_variants),
+ 0 /*SPINAND_HAS_QE_BIT*/,
+ SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+ mx35lf1ge4ab_ecc_get_status)),
+ SPINAND_INFO("MX35LF4GE4AD",
+ SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x37),
+ NAND_MEMORG(1, 4096, 128, 64, 2048, 40, 1, 1, 1),
+ NAND_ECCREQ(8, 512),
+ SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
+ &write_cache_variants,
+ &update_cache_variants),
+ 0 /*SPINAND_HAS_QE_BIT*/,
+ SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
+ mx35lf1ge4ab_ecc_get_status)),
SPINAND_INFO("MX31LF1GE4BC",
SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x1e),
NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD
2020-11-04 11:47 [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD YouChing Lin
@ 2020-11-04 17:44 ` Miquel Raynal
2020-11-19 21:11 ` Miquel Raynal
1 sibling, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2020-11-04 17:44 UTC (permalink / raw)
To: YouChing Lin
Cc: richard, vigneshr, juliensu, gch981213, linux-mtd, linux-kernel
Hi YouChing,
YouChing Lin <ycllin@mxic.com.tw> wrote on Wed, 4 Nov 2020 19:47:22
+0800:
> The Macronix MX35LF2GE4AD / MX35LF4GE4AD are 3V, 2G / 4Gbit serial
> SLC NAND flash device (with on-die ECC).
>
> Validated by read, erase, read back, write, read back and nandtest
> on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host
> (drivers/spi/spi-mxic.c).
>
> Signed-off-by: YouChing Lin <ycllin@mxic.com.tw>
> ---
> drivers/mtd/nand/spi/macronix.c | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
>
> diff --git a/drivers/mtd/nand/spi/macronix.c b/drivers/mtd/nand/spi/macronix.c
> index 8e801e4..4f7f954 100644
> --- a/drivers/mtd/nand/spi/macronix.c
> +++ b/drivers/mtd/nand/spi/macronix.c
> @@ -119,6 +119,26 @@ static int mx35lf1ge4ab_ecc_get_status(struct spinand_device *spinand,
> &update_cache_variants),
> SPINAND_HAS_QE_BIT,
> SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout, NULL)),
> + SPINAND_INFO("MX35LF2GE4AD",
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x26),
> + NAND_MEMORG(1, 2048, 64, 64, 2048, 40, 1, 1, 1),
> + NAND_ECCREQ(8, 512),
> + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> + &write_cache_variants,
> + &update_cache_variants),
> + 0 /*SPINAND_HAS_QE_BIT*/,
What is the purpose of this comment? Shouldn't get rid of it and just
keep '0' if the QE bit is not supported?
> + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
> + mx35lf1ge4ab_ecc_get_status)),
> + SPINAND_INFO("MX35LF4GE4AD",
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x37),
> + NAND_MEMORG(1, 4096, 128, 64, 2048, 40, 1, 1, 1),
> + NAND_ECCREQ(8, 512),
> + SPINAND_INFO_OP_VARIANTS(&read_cache_variants,
> + &write_cache_variants,
> + &update_cache_variants),
> + 0 /*SPINAND_HAS_QE_BIT*/,
Ditto
> + SPINAND_ECCINFO(&mx35lfxge4ab_ooblayout,
> + mx35lf1ge4ab_ecc_get_status)),
> SPINAND_INFO("MX31LF1GE4BC",
> SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x1e),
> NAND_MEMORG(1, 2048, 64, 64, 1024, 20, 1, 1, 1),
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD
2020-11-04 11:47 [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD YouChing Lin
2020-11-04 17:44 ` Miquel Raynal
@ 2020-11-19 21:11 ` Miquel Raynal
2020-11-19 21:15 ` Miquel Raynal
1 sibling, 1 reply; 5+ messages in thread
From: Miquel Raynal @ 2020-11-19 21:11 UTC (permalink / raw)
To: YouChing Lin, miquel.raynal, richard, vigneshr
Cc: juliensu, linux-mtd, gch981213, linux-kernel
On Wed, 2020-11-04 at 11:47:22 UTC, YouChing Lin wrote:
> The Macronix MX35LF2GE4AD / MX35LF4GE4AD are 3V, 2G / 4Gbit serial
> SLC NAND flash device (with on-die ECC).
>
> Validated by read, erase, read back, write, read back and nandtest
> on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host
> (drivers/spi/spi-mxic.c).
>
> Signed-off-by: YouChing Lin <ycllin@mxic.com.tw>
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Miquel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD
2020-11-19 21:11 ` Miquel Raynal
@ 2020-11-19 21:15 ` Miquel Raynal
2020-11-20 1:10 ` 回信: " ycllin
0 siblings, 1 reply; 5+ messages in thread
From: Miquel Raynal @ 2020-11-19 21:15 UTC (permalink / raw)
To: YouChing Lin, miquel.raynal, richard, vigneshr
Cc: juliensu, linux-mtd, gch981213, linux-kernel
Hello
Miquel Raynal <miquel.raynal@bootlin.com> wrote on Thu, 19 Nov 2020
22:11:33 +0100:
> On Wed, 2020-11-04 at 11:47:22 UTC, YouChing Lin wrote:
> > The Macronix MX35LF2GE4AD / MX35LF4GE4AD are 3V, 2G / 4Gbit serial
> > SLC NAND flash device (with on-die ECC).
> >
> > Validated by read, erase, read back, write, read back and nandtest
> > on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host
> > (drivers/spi/spi-mxic.c).
> >
> > Signed-off-by: YouChing Lin <ycllin@mxic.com.tw>
>
> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.
Please use "v2" as prefix next time you change something in your patch
instead of "RESEND", it confuses me. I applied the wrong patch, I will
drop this one and take the "RESEND, v1" instead.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 5+ messages in thread
* 回信: Re: [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD
2020-11-19 21:15 ` Miquel Raynal
@ 2020-11-20 1:10 ` ycllin
0 siblings, 0 replies; 5+ messages in thread
From: ycllin @ 2020-11-20 1:10 UTC (permalink / raw)
To: Miquel Raynal; +Cc: juliensu, linux-kernel, linux-mtd, richard, vigneshr
Hi Miquel,
> Miquel Raynal <miquel.raynal@bootlin.com> wrote on Thu, 19 Nov 2020
> 22:11:33 +0100:
>
> > On Wed, 2020-11-04 at 11:47:22 UTC, YouChing Lin wrote:
> > > The Macronix MX35LF2GE4AD / MX35LF4GE4AD are 3V, 2G / 4Gbit serial
> > > SLC NAND flash device (with on-die ECC).
> > >
> > > Validated by read, erase, read back, write, read back and nandtest
> > > on Xilinx Zynq PicoZed FPGA board which included Macronix SPI Host
> > > (drivers/spi/spi-mxic.c).
> > >
> > > Signed-off-by: YouChing Lin <ycllin@mxic.com.tw>
> >
> > Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> nand/next, thanks.
>
> Please use "v2" as prefix next time you change something in your patch
> instead of "RESEND", it confuses me. I applied the wrong patch, I will
> drop this one and take the "RESEND, v1" instead.
OK, I got it, sorry for the mistake!
Thanks for your time.
YouChing.
>
> Thanks,
> Miquèl
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
============================================================================
CONFIDENTIALITY NOTE:
This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.
Macronix International Co., Ltd.
=====================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-20 1:20 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-04 11:47 [PATCH] mtd: spinand: macronix: Add support for MX35LFxGE4AD YouChing Lin
2020-11-04 17:44 ` Miquel Raynal
2020-11-19 21:11 ` Miquel Raynal
2020-11-19 21:15 ` Miquel Raynal
2020-11-20 1:10 ` 回信: " ycllin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).