Hi Yong, Thank you for the patch! Yet something to improve: [auto build test ERROR on iommu/next] [also build test ERROR on tegra/for-next arm-perf/for-next/perf v5.10-rc4 next-20201119] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Yong-Wu/MediaTek-IOMMU-improve-tlb-flush-performance-in-map-unmap/20201119-142620 base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next config: m68k-randconfig-r001-20201119 (attached as .config) compiler: m68k-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/7b8f6281690f7b2c2dbdfdabb6196bc29690c9ed git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Yong-Wu/MediaTek-IOMMU-improve-tlb-flush-performance-in-map-unmap/20201119-142620 git checkout 7b8f6281690f7b2c2dbdfdabb6196bc29690c9ed # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from include/asm-generic/bug.h:5, from arch/m68k/include/asm/bug.h:32, from include/linux/bug.h:5, from drivers/iommu/mtk_iommu.c:6: include/linux/scatterlist.h: In function 'sg_set_buf': arch/m68k/include/asm/page_mm.h:169:49: warning: ordered comparison of pointer with null pointer [-Wextra] 169 | #define virt_addr_valid(kaddr) ((void *)(kaddr) >= (void *)PAGE_OFFSET && (void *)(kaddr) < high_memory) | ^~ include/linux/compiler.h:78:42: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ include/linux/scatterlist.h:143:2: note: in expansion of macro 'BUG_ON' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~ include/linux/scatterlist.h:143:10: note: in expansion of macro 'virt_addr_valid' 143 | BUG_ON(!virt_addr_valid(buf)); | ^~~~~~~~~~~~~~~ drivers/iommu/mtk_iommu.c: In function 'mtk_iommu_sync_map': >> drivers/iommu/mtk_iommu.c:461:54: error: 'struct mtk_iommu_domain' has no member named 'data' 461 | mtk_iommu_tlb_flush_range_sync(iova, size, size, dom->data); | ^~ vim +461 drivers/iommu/mtk_iommu.c 455 456 static void mtk_iommu_sync_map(struct iommu_domain *domain, unsigned long iova, 457 size_t size) 458 { 459 struct mtk_iommu_domain *dom = to_mtk_domain(domain); 460 > 461 mtk_iommu_tlb_flush_range_sync(iova, size, size, dom->data); 462 } 463 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org