archive mirror
 help / color / mirror / Atom feed
* [PATCH] lib/string: remove unnecessary #undefs
@ 2020-11-20  4:11 Nick Desaulniers
  0 siblings, 0 replies; only message in thread
From: Nick Desaulniers @ 2020-11-20  4:11 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Nick Desaulniers, Andy Shevchenko, Yury Norov,
	Alexandru Ardelean, Nathan Chancellor, Masahiro Yamada,

A few architecture specific string.h functions used to be implemented in
terms of preprocessor defines to the corresponding compiler builtins.
Since this is no longer the case, remove unused #undefs.

Only memcmp is still defined in terms of builtins for a few arches.

Fixes: 5f074f3e192f ("lib/string.c: implement a basic bcmp")
Signed-off-by: Nick Desaulniers <>
 lib/string.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/string.c b/lib/string.c
index 4288e0158d47..7548eb715ddb 100644
--- a/lib/string.c
+++ b/lib/string.c
@@ -85,7 +85,6 @@ EXPORT_SYMBOL(strcasecmp);
  * @dest: Where to copy the string to
  * @src: Where to copy the string from
-#undef strcpy
 char *strcpy(char *dest, const char *src)
 	char *tmp = dest;
@@ -302,7 +301,6 @@ EXPORT_SYMBOL(stpcpy);
  * @dest: The string to be appended to
  * @src: The string to append to it
-#undef strcat
 char *strcat(char *dest, const char *src)
 	char *tmp = dest;
@@ -378,7 +376,6 @@ EXPORT_SYMBOL(strlcat);
  * @cs: One string
  * @ct: Another string
-#undef strcmp
 int strcmp(const char *cs, const char *ct)
 	unsigned char c1, c2;
@@ -958,7 +955,6 @@ EXPORT_SYMBOL(memcmp);
  * while this particular implementation is a simple (tail) call to memcmp, do
  * not rely on anything but whether the return value is zero or non-zero.
-#undef bcmp
 int bcmp(const void *a, const void *b, size_t len)
 	return memcmp(a, b, len);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-11-20  4:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20  4:11 [PATCH] lib/string: remove unnecessary #undefs Nick Desaulniers

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).