From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Bhaumik Bhatt <bbhatt@codeaurora.org>,
kvalo@codeaurora.org, linux-wireless@vger.kernel.org,
cjhuang@codeaurora.org, linux-arm-msm@vger.kernel.org,
hemantk@codeaurora.org, linux-kernel@vger.kernel.org,
ath11k@lists.infradead.org, clew@codeaurora.org,
loic.poulain@linaro.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: qrtr: Unprepare MHI channels during remove
Date: Fri, 20 Nov 2020 11:45:12 +0530 [thread overview]
Message-ID: <20201120061512.GB3909@work> (raw)
In-Reply-To: <20201119211046.64294cf6@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
On Thu, Nov 19, 2020 at 09:10:46PM -0800, Jakub Kicinski wrote:
> On Wed, 18 Nov 2020 10:20:25 -0800 Bhaumik Bhatt wrote:
> > Reset MHI device channels when driver remove is called due to
> > module unload or any crash scenario. This will make sure that
> > MHI channels no longer remain enabled for transfers since the
> > MHI stack does not take care of this anymore after the auto-start
> > channels feature was removed.
> >
> > Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
>
> Patch seems reasonable, Mani are you taking it or should I?
>
Since I already picked up one qrtr patch, makese sense to pick this
also.
> Bhaumik would you mind adding a Fixes tag to be clear where
> the issue was introduced?
This is due to the MHI auto-start change which just got queued into
mhi-next. I don't think we need a Fixes tag.
Jakub, can you please provide your ack so that I can take it?
Thanks,
Mani
next prev parent reply other threads:[~2020-11-20 6:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 18:20 [PATCH] net: qrtr: Unprepare MHI channels during remove Bhaumik Bhatt
2020-11-18 18:34 ` Jeffrey Hugo
2020-11-18 19:13 ` Bhaumik Bhatt
[not found] ` <CAMZdPi_b0=qFNGi1yUke3Dip2bi-zW4ULTg8W4nbyPyEsE3D4w@mail.gmail.com>
2020-11-18 19:34 ` Jeffrey Hugo
2020-11-19 19:02 ` Bhaumik Bhatt
2020-11-25 18:01 ` Jeffrey Hugo
2020-11-20 5:10 ` Jakub Kicinski
2020-11-20 6:15 ` Manivannan Sadhasivam [this message]
2020-11-20 6:18 ` Jakub Kicinski
2020-11-20 6:23 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120061512.GB3909@work \
--to=manivannan.sadhasivam@linaro.org \
--cc=ath11k@lists.infradead.org \
--cc=bbhatt@codeaurora.org \
--cc=cjhuang@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).