From: Xu Yilun <yilun.xu@intel.com>
To: David Gow <davidgow@google.com>
Cc: Moritz Fischer <mdf@kernel.org>, Tom Rix <trix@redhat.com>,
linux-fpga@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-um <linux-um@lists.infradead.org>,
Brendan Higgins <brendanhiggins@google.com>
Subject: Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
Date: Fri, 20 Nov 2020 15:40:13 +0800 [thread overview]
Message-ID: <20201120074012.GB12837@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <CABVgOSmat7h9qqtEokwX69Aj-Q5AiAxU2G3yz_4ZMpmAArur7w@mail.gmail.com>
On Fri, Nov 20, 2020 at 03:30:35PM +0800, David Gow wrote:
> On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer <mdf@kernel.org> wrote:
> >
> > Hi David,
> >
> > On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> > > functions, it should depend on HAS_IOMEM.
> > >
> > > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> > > HAS_IOMEM.
> > >
> > > Signed-off-by: David Gow <davidgow@google.com>
> > > ---
> > > drivers/fpga/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > > index 7cd5a29fc437..5645226ca3ce 100644
> > > --- a/drivers/fpga/Kconfig
> > > +++ b/drivers/fpga/Kconfig
> > > @@ -142,6 +142,7 @@ config FPGA_DFL
> > > tristate "FPGA Device Feature List (DFL) support"
> > > select FPGA_BRIDGE
> > > select FPGA_REGION
> > > + depends on HAS_IOMEM
> > > help
> > > Device Feature List (DFL) defines a feature list structure that
> > > creates a linked list of feature headers within the MMIO space
> > > --
> > > 2.29.2.454.gaff20da3a2-goog
> > >
> > Do you think we can add a Fixes: tag for this?
>
> Sure. I think it should be:
>
> Fixes: 543be3d ("fpga: add device feature list support")
I think it should be:
Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
Thanks,
Yilun
>
> Let me know if you want me to re-send the patch with that included.
>
> Cheers,
> -- David
next prev parent reply other threads:[~2020-11-20 7:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 8:22 [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL David Gow
2020-11-19 11:13 ` Xu Yilun
2020-11-20 6:27 ` Moritz Fischer
2020-11-20 7:30 ` David Gow
2020-11-20 7:40 ` Xu Yilun [this message]
2020-11-20 21:48 ` Moritz Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120074012.GB12837@yilunxu-OptiPlex-7050 \
--to=yilun.xu@intel.com \
--cc=brendanhiggins@google.com \
--cc=davidgow@google.com \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=mdf@kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).