linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
@ 2020-11-19  8:22 David Gow
  2020-11-19 11:13 ` Xu Yilun
  2020-11-20  6:27 ` Moritz Fischer
  0 siblings, 2 replies; 6+ messages in thread
From: David Gow @ 2020-11-19  8:22 UTC (permalink / raw)
  To: Moritz Fischer, Tom Rix
  Cc: linux-fpga, linux-kernel, linux-um, Brendan Higgins, David Gow

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
HAS_IOMEM.

Signed-off-by: David Gow <davidgow@google.com>
---
 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 7cd5a29fc437..5645226ca3ce 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
-- 
2.29.2.454.gaff20da3a2-goog


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
  2020-11-19  8:22 [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL David Gow
@ 2020-11-19 11:13 ` Xu Yilun
  2020-11-20  6:27 ` Moritz Fischer
  1 sibling, 0 replies; 6+ messages in thread
From: Xu Yilun @ 2020-11-19 11:13 UTC (permalink / raw)
  To: David Gow
  Cc: Moritz Fischer, Tom Rix, linux-fpga, linux-kernel, linux-um,
	Brendan Higgins

Thanks for the fix, looks good to me.

Thanks,
Yilun

On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> functions, it should depend on HAS_IOMEM.
> 
> This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> HAS_IOMEM.
> 
> Signed-off-by: David Gow <davidgow@google.com>
> ---
>  drivers/fpga/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 7cd5a29fc437..5645226ca3ce 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -142,6 +142,7 @@ config FPGA_DFL
>  	tristate "FPGA Device Feature List (DFL) support"
>  	select FPGA_BRIDGE
>  	select FPGA_REGION
> +	depends on HAS_IOMEM
>  	help
>  	  Device Feature List (DFL) defines a feature list structure that
>  	  creates a linked list of feature headers within the MMIO space
> -- 
> 2.29.2.454.gaff20da3a2-goog

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
  2020-11-19  8:22 [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL David Gow
  2020-11-19 11:13 ` Xu Yilun
@ 2020-11-20  6:27 ` Moritz Fischer
  2020-11-20  7:30   ` David Gow
  1 sibling, 1 reply; 6+ messages in thread
From: Moritz Fischer @ 2020-11-20  6:27 UTC (permalink / raw)
  To: David Gow
  Cc: Moritz Fischer, Tom Rix, linux-fpga, linux-kernel, linux-um,
	Brendan Higgins

Hi David,

On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> functions, it should depend on HAS_IOMEM.
> 
> This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> HAS_IOMEM.
> 
> Signed-off-by: David Gow <davidgow@google.com>
> ---
>  drivers/fpga/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 7cd5a29fc437..5645226ca3ce 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -142,6 +142,7 @@ config FPGA_DFL
>  	tristate "FPGA Device Feature List (DFL) support"
>  	select FPGA_BRIDGE
>  	select FPGA_REGION
> +	depends on HAS_IOMEM
>  	help
>  	  Device Feature List (DFL) defines a feature list structure that
>  	  creates a linked list of feature headers within the MMIO space
> -- 
> 2.29.2.454.gaff20da3a2-goog
> 
Do you think we can add a Fixes: tag for this?

Thanks,
Moritz

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
  2020-11-20  6:27 ` Moritz Fischer
@ 2020-11-20  7:30   ` David Gow
  2020-11-20  7:40     ` Xu Yilun
  0 siblings, 1 reply; 6+ messages in thread
From: David Gow @ 2020-11-20  7:30 UTC (permalink / raw)
  To: Moritz Fischer
  Cc: Tom Rix, linux-fpga, Linux Kernel Mailing List, linux-um,
	Brendan Higgins

On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer <mdf@kernel.org> wrote:
>
> Hi David,
>
> On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> > functions, it should depend on HAS_IOMEM.
> >
> > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> > HAS_IOMEM.
> >
> > Signed-off-by: David Gow <davidgow@google.com>
> > ---
> >  drivers/fpga/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > index 7cd5a29fc437..5645226ca3ce 100644
> > --- a/drivers/fpga/Kconfig
> > +++ b/drivers/fpga/Kconfig
> > @@ -142,6 +142,7 @@ config FPGA_DFL
> >       tristate "FPGA Device Feature List (DFL) support"
> >       select FPGA_BRIDGE
> >       select FPGA_REGION
> > +     depends on HAS_IOMEM
> >       help
> >         Device Feature List (DFL) defines a feature list structure that
> >         creates a linked list of feature headers within the MMIO space
> > --
> > 2.29.2.454.gaff20da3a2-goog
> >
> Do you think we can add a Fixes: tag for this?

Sure. I think it should be:

Fixes: 543be3d ("fpga: add device feature list support")

Let me know if you want me to re-send the patch with that included.

Cheers,
-- David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
  2020-11-20  7:30   ` David Gow
@ 2020-11-20  7:40     ` Xu Yilun
  2020-11-20 21:48       ` Moritz Fischer
  0 siblings, 1 reply; 6+ messages in thread
From: Xu Yilun @ 2020-11-20  7:40 UTC (permalink / raw)
  To: David Gow
  Cc: Moritz Fischer, Tom Rix, linux-fpga, Linux Kernel Mailing List,
	linux-um, Brendan Higgins

On Fri, Nov 20, 2020 at 03:30:35PM +0800, David Gow wrote:
> On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer <mdf@kernel.org> wrote:
> >
> > Hi David,
> >
> > On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> > > functions, it should depend on HAS_IOMEM.
> > >
> > > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> > > HAS_IOMEM.
> > >
> > > Signed-off-by: David Gow <davidgow@google.com>
> > > ---
> > >  drivers/fpga/Kconfig | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > > index 7cd5a29fc437..5645226ca3ce 100644
> > > --- a/drivers/fpga/Kconfig
> > > +++ b/drivers/fpga/Kconfig
> > > @@ -142,6 +142,7 @@ config FPGA_DFL
> > >       tristate "FPGA Device Feature List (DFL) support"
> > >       select FPGA_BRIDGE
> > >       select FPGA_REGION
> > > +     depends on HAS_IOMEM
> > >       help
> > >         Device Feature List (DFL) defines a feature list structure that
> > >         creates a linked list of feature headers within the MMIO space
> > > --
> > > 2.29.2.454.gaff20da3a2-goog
> > >
> > Do you think we can add a Fixes: tag for this?
> 
> Sure. I think it should be:
> 
> Fixes: 543be3d ("fpga: add device feature list support")

I think it should be:

Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")

Thanks,
Yilun

> 
> Let me know if you want me to re-send the patch with that included.
> 
> Cheers,
> -- David

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
  2020-11-20  7:40     ` Xu Yilun
@ 2020-11-20 21:48       ` Moritz Fischer
  0 siblings, 0 replies; 6+ messages in thread
From: Moritz Fischer @ 2020-11-20 21:48 UTC (permalink / raw)
  To: Xu Yilun
  Cc: David Gow, Moritz Fischer, Tom Rix, linux-fpga,
	Linux Kernel Mailing List, linux-um, Brendan Higgins

Hi David,

On Fri, Nov 20, 2020 at 03:40:13PM +0800, Xu Yilun wrote:
> On Fri, Nov 20, 2020 at 03:30:35PM +0800, David Gow wrote:
> > On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer <mdf@kernel.org> wrote:
> > >
> > > Hi David,
> > >
> > > On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote:
> > > > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> > > > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> > > > functions, it should depend on HAS_IOMEM.
> > > >
> > > > This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> > > > HAS_IOMEM.
> > > >
> > > > Signed-off-by: David Gow <davidgow@google.com>
> > > > ---
> > > >  drivers/fpga/Kconfig | 1 +
> > > >  1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> > > > index 7cd5a29fc437..5645226ca3ce 100644
> > > > --- a/drivers/fpga/Kconfig
> > > > +++ b/drivers/fpga/Kconfig
> > > > @@ -142,6 +142,7 @@ config FPGA_DFL
> > > >       tristate "FPGA Device Feature List (DFL) support"
> > > >       select FPGA_BRIDGE
> > > >       select FPGA_REGION
> > > > +     depends on HAS_IOMEM
> > > >       help
> > > >         Device Feature List (DFL) defines a feature list structure that
> > > >         creates a linked list of feature headers within the MMIO space
> > > > --
> > > > 2.29.2.454.gaff20da3a2-goog
> > > >
> > > Do you think we can add a Fixes: tag for this?
> > 
> > Sure. I think it should be:
> > 
> > Fixes: 543be3d ("fpga: add device feature list support")
> 
> I think it should be:
> 
> Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
I think so, yes.

Can you resend?

Cheers

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-11-20 21:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-19  8:22 [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL David Gow
2020-11-19 11:13 ` Xu Yilun
2020-11-20  6:27 ` Moritz Fischer
2020-11-20  7:30   ` David Gow
2020-11-20  7:40     ` Xu Yilun
2020-11-20 21:48       ` Moritz Fischer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).