From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
Ming Lei <ming.lei@redhat.com>,
linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] iov_iter: optimise iov_iter_npages for bvec
Date: Fri, 20 Nov 2020 08:14:29 +0000 [thread overview]
Message-ID: <20201120081429.GA30801@infradead.org> (raw)
In-Reply-To: <20201120025457.GM29991@casper.infradead.org>
On Fri, Nov 20, 2020 at 02:54:57AM +0000, Matthew Wilcox wrote:
> On Fri, Nov 20, 2020 at 02:25:08AM +0000, Pavel Begunkov wrote:
> > On 20/11/2020 02:22, Ming Lei wrote:
> > > iov_iter_npages(bvec) still can be improved a bit by the following way:
> >
> > Yep, was doing exactly that, +a couple of other places that are in my way.
>
> Are you optimising the right thing here? Assuming you're looking at
> the one in do_blockdev_direct_IO(), wouldn't we be better off figuring
> out how to copy the bvecs directly from the iov_iter into the bio
> rather than calling dio_bio_add_page() for each page?
Which is most effectively done by stopping to to use *blockdev_direct_IO
and switching to iomap instead :)
next prev parent reply other threads:[~2020-11-20 8:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 23:24 [PATCH v2 0/2] optimise iov_iter Pavel Begunkov
2020-11-19 23:24 ` [PATCH v2 1/2] iov_iter: optimise iov_iter_npages for bvec Pavel Begunkov
2020-11-20 1:20 ` Matthew Wilcox
2020-11-20 1:39 ` Pavel Begunkov
2020-11-20 1:49 ` Matthew Wilcox
2020-11-20 1:56 ` Pavel Begunkov
2020-11-20 2:06 ` Matthew Wilcox
2020-11-20 2:08 ` Pavel Begunkov
2020-11-20 2:24 ` Ming Lei
2020-11-20 17:22 ` Pavel Begunkov
2020-11-20 17:23 ` Pavel Begunkov
2020-11-20 2:22 ` Ming Lei
2020-11-20 2:25 ` Pavel Begunkov
2020-11-20 2:54 ` Matthew Wilcox
2020-11-20 8:14 ` Christoph Hellwig [this message]
2020-11-20 12:39 ` Matthew Wilcox
2020-11-20 13:00 ` Pavel Begunkov
2020-11-20 13:13 ` Matthew Wilcox
2020-11-20 9:57 ` Pavel Begunkov
2020-11-20 13:29 ` David Laight
2020-11-19 23:24 ` [PATCH v2 2/2] iov_iter: optimise iter type checking Pavel Begunkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120081429.GA30801@infradead.org \
--to=hch@infradead.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).