From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Prashant Malani <pmalani@chromium.org>
Cc: Utkarsh Patel <utkarsh.h.patel@intel.com>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
enric.balletbo@collabora.com, rajmohan.mani@intel.com,
azhar.shaikh@intel.com
Subject: Re: [PATCH v3 1/4] usb: typec: Use Thunderbolt 3 cable discover mode VDO in Enter_USB message
Date: Fri, 20 Nov 2020 10:52:50 +0200 [thread overview]
Message-ID: <20201120085250.GD4120550@kuha.fi.intel.com> (raw)
In-Reply-To: <20201120083625.GB4160865@google.com>
On Fri, Nov 20, 2020 at 12:36:25AM -0800, Prashant Malani wrote:
> On Fri, Nov 20, 2020 at 10:05:14AM +0200, Heikki Krogerus wrote:
> > On Wed, Nov 18, 2020 at 10:32:08PM -0800, Utkarsh Patel wrote:
> > > When Thunderbolt 3 cable is being used to create USB4 connection, use
> > > Thunderbolt 3 discover mode VDO to fill details such as active cable plug
> > > link training and cable rounded support.
> > > With USB4 cables, these VDO members need not be filled.
> > >
> > > Suggested-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > > Signed-off-by: Utkarsh Patel <utkarsh.h.patel@intel.com>
> > >
> > > --
> > > Changes in v3:
> > > - Changed the commit mesage to reflect why TBT3 VDO is being used.
> > > - Added more details in the header file about the usage of TBT3 VDO.
> > >
> > > Changes in v2:
> > > - No change.
> > > --
> > > ---
> > > include/linux/usb/typec.h | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h
> > > index 6be558045942..25731ed863fa 100644
> > > --- a/include/linux/usb/typec.h
> > > +++ b/include/linux/usb/typec.h
> > > @@ -75,6 +75,10 @@ enum typec_orientation {
> > > /*
> > > * struct enter_usb_data - Enter_USB Message details
> > > * @eudo: Enter_USB Data Object
> > > + * @tbt_cable_vdo: TBT3 Cable Discover Mode Response
> >
> > This is fine..
> >
> > > + * @tbt_cable_vdo needs to be filled with details of active cable plug link
> > > + * training and cable rounded support when thunderbolt 3 cable is being used to
> > > + * create USB4 connection. Do not fill this in case of USB4 cable.
> >
> > But this is not. The description of the member tells what the member
> > contains, but it does not make sense to explain also how to use the
> > member in the same place.
>
> Slightly tangential question here:
>
> Is there a need to mention "active cable plug link training" and "cable
> rounded support" at all? Wouldn't it be sufficient to omit those in the
> description (in case some mux implementation wants to use the other fields
> of the VDO) ?
No, I don't think so. I think it would be enough to just mention that
we need the TBT3 Cable VDO only when the USB4 connection is created
using TBT3 cables. And that's it.
Br,
--
heikki
next prev parent reply other threads:[~2020-11-20 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 6:32 [PATCH v3 0/4] Thunderbolt3/USB4 cable rounded and active cable plug link training support Utkarsh Patel
2020-11-19 6:32 ` [PATCH v3 1/4] usb: typec: Use Thunderbolt 3 cable discover mode VDO in Enter_USB message Utkarsh Patel
2020-11-20 8:05 ` Heikki Krogerus
2020-11-20 8:36 ` Prashant Malani
2020-11-20 8:52 ` Heikki Krogerus [this message]
2020-11-20 17:04 ` Patel, Utkarsh H
2020-11-19 6:32 ` [PATCH v3 2/4] platform/chrome: cros_ec_typec: Use Thunderbolt 3 cable discover mode VDO in USB4 mode Utkarsh Patel
2020-11-19 8:09 ` Prashant Malani
2020-11-20 2:32 ` Patel, Utkarsh H
2020-11-20 3:13 ` Prashant Malani
2020-11-20 11:22 ` Heikki Krogerus
2020-11-20 12:07 ` Prashant Malani
2020-11-20 13:36 ` Prashant Malani
2020-11-20 13:41 ` Heikki Krogerus
2020-11-19 6:32 ` [PATCH v3 3/4] usb: typec: intel_pmc_mux: Configure active cable properties for USB4 Utkarsh Patel
2020-11-19 6:32 ` [PATCH v3 4/4] usb: typec: Remove active_link_training variable from Enter_USB message Utkarsh Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120085250.GD4120550@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=azhar.shaikh@intel.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pmalani@chromium.org \
--cc=rajmohan.mani@intel.com \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).