From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 192D4C64E7C for ; Fri, 20 Nov 2020 18:29:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B12662469D for ; Fri, 20 Nov 2020 18:29:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="MUqSj9NO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730391AbgKTS2c (ORCPT ); Fri, 20 Nov 2020 13:28:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:48876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729771AbgKTS22 (ORCPT ); Fri, 20 Nov 2020 13:28:28 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE97A24137; Fri, 20 Nov 2020 18:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605896908; bh=WqCP34BthLI/V/Ugps1321WWg/uGOwp1Bkswcw5xH0w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MUqSj9NOYZZn11h/pN7O2p8V/X30PrdaxH50CVuf4Sx707ujgZ3eddduMZ1DGNc1J mXCKOzblr4ZVOJKifszj/vaZYKp3T6D1jlyBkcZOWWMW7yZYgLuL+eJgFU4BL4Bspr 1xcLf871ltFEmnZxhDbTeJUGMGIyeLXluPNBBoJw= Date: Fri, 20 Nov 2020 10:28:27 -0800 From: Jakub Kicinski To: Martin Schiller Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v5] net/tun: Call netdev notifiers Message-ID: <20201120102827.6b432dc5@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201118063919.29485-1-ms@dev.tdt.de> References: <20201118063919.29485-1-ms@dev.tdt.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Nov 2020 07:39:19 +0100 Martin Schiller wrote: > Call netdev notifiers before and after changing the device type. > > Signed-off-by: Martin Schiller This is a fix, right? Can you give an example of something that goes wrong without this patch?