From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E625C5519F for ; Fri, 20 Nov 2020 12:08:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E11702100A for ; Fri, 20 Nov 2020 12:08:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fRHC2Nb6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727988AbgKTMIR (ORCPT ); Fri, 20 Nov 2020 07:08:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727070AbgKTMIP (ORCPT ); Fri, 20 Nov 2020 07:08:15 -0500 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89350C0613CF for ; Fri, 20 Nov 2020 04:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vlXR+DeDm58p736gPlu4ZNiSJsmquQxprWhu8Q3iIL8=; b=fRHC2Nb6zcdTb+UFSiq7GQRUml BUcux3dn7RsKDlz4v+LiwCLL5XUhYCq1gUqZpb9juEnjSzn/4qQQIeiFL1LSLrh9HtqKFvu6oo2fy YaGX3kbhn8wEu45EEmSdWXGs1CGyP3hJ72OQrgns8cznCA9Yy75jioH9PKqiPbWVoPm3nex2Aw93R vbfyV+gyoMK/k6uyjezWSI2d4xiZaaa/qfdcjAV7GkIz2Ijn5O6uyxpTUYsOj7IwiraWKv9KDE44j HymhtOgRlYegJPkO3F0EUjLjhaP7ZarIEGVFdAeQafXl7tla9cn5tt/6O/8+i0vh5behC/4jxjuIo bAK0zS/w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kg5Cx-0004e7-7B; Fri, 20 Nov 2020 12:08:07 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id DB2573069B1; Fri, 20 Nov 2020 13:08:05 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id C6997200EC4FD; Fri, 20 Nov 2020 13:08:05 +0100 (CET) Date: Fri, 20 Nov 2020 13:08:05 +0100 From: Peter Zijlstra To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, luto@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Deep Shah , "VMware, Inc." Subject: Re: [PATCH v2 08/12] x86/paravirt: remove no longer needed 32-bit pvops cruft Message-ID: <20201120120805.GF3021@hirez.programming.kicks-ass.net> References: <20201120114630.13552-1-jgross@suse.com> <20201120114630.13552-9-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201120114630.13552-9-jgross@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 12:46:26PM +0100, Juergen Gross wrote: > +#define ____PVOP_CALL(rettype, op, clbr, call_clbr, extra_clbr, ...) \ > ({ \ > PVOP_CALL_ARGS; \ > PVOP_TEST_NULL(op); \ > + BUILD_BUG_ON(sizeof(rettype) > sizeof(unsigned long)); \ > + asm volatile(paravirt_alt(PARAVIRT_CALL) \ > + : call_clbr, ASM_CALL_CONSTRAINT \ > + : paravirt_type(op), \ > + paravirt_clobber(clbr), \ > + ##__VA_ARGS__ \ > + : "memory", "cc" extra_clbr); \ > + (rettype)(__eax & PVOP_RETMASK(rettype)); \ > }) This is now very similar to ____PVOP_VCALL() (note how PVOP_CALL_ARGS is PVOP_VCALL_ARGS). Could we get away with doing something horrible like: #define ____PVOP_VCALL(X...) (void)____PVOP_CALL(long, X) ?