From: Serge Semin <fancer.lancer@gmail.com>
To: Qinglang Miao <miaoqinglang@huawei.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: cdmm: fix use-after-free in mips_cdmm_bus_discover
Date: Fri, 20 Nov 2020 17:06:54 +0300 [thread overview]
Message-ID: <20201120140654.e3jrnnyqesqbsko3@mobilestation> (raw)
In-Reply-To: <20201120074847.31369-1-miaoqinglang@huawei.com>
Hello Qinglang
Thanks for the patch. Good catch. Please see a tiny nitpick below.
On Fri, Nov 20, 2020 at 03:48:47PM +0800, Qinglang Miao wrote:
> kfree(dev) has been called inside put_device so anther
> kfree would cause a use-after-free bug/
>
> Fixes: 8286ae03308c ("MIPS: Add CDMM bus support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
> drivers/bus/mips_cdmm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/mips_cdmm.c b/drivers/bus/mips_cdmm.c
> index 9f7ed1fcd..e43786c67 100644
> --- a/drivers/bus/mips_cdmm.c
> +++ b/drivers/bus/mips_cdmm.c
> @@ -561,7 +561,6 @@ static void mips_cdmm_bus_discover(struct mips_cdmm_bus *bus)
> ret = device_register(&dev->dev);
> if (ret) {
> put_device(&dev->dev);
> - kfree(dev);
> }
After removing kfree() from here the braces around the if clause
are no more needed in accordance with the kernel coding style.
Please remove them too. Then feel free to add the tag
Acked-by: Serge Semin <fancer.lancer@gmail.com>
-Sergey
> }
> }
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-11-20 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 7:48 [PATCH] mips: cdmm: fix use-after-free in mips_cdmm_bus_discover Qinglang Miao
2020-11-20 14:06 ` Serge Semin [this message]
2020-11-27 9:33 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201120140654.e3jrnnyqesqbsko3@mobilestation \
--to=fancer.lancer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=miaoqinglang@huawei.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).