From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A291C2D0E4 for ; Fri, 20 Nov 2020 16:55:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D7F972240B for ; Fri, 20 Nov 2020 16:55:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=joelfernandes.org header.i=@joelfernandes.org header.b="A7nnsNFz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730179AbgKTQz1 (ORCPT ); Fri, 20 Nov 2020 11:55:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729569AbgKTQz0 (ORCPT ); Fri, 20 Nov 2020 11:55:26 -0500 Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 754A4C0613CF for ; Fri, 20 Nov 2020 08:55:26 -0800 (PST) Received: by mail-qt1-x82e.google.com with SMTP id f15so4064334qto.13 for ; Fri, 20 Nov 2020 08:55:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fP9H0NfmnH39CvoMhVDgN4MIBYLW4dx4A1D7re6k5gk=; b=A7nnsNFzrs19WzwXPOcfgoQ5JHYBzmxO1EAo4F5bjJ8eWLbxaMFpV+Y6jHXGPB3hUW k9XxBfRkz+BbHIjQOg9kQ9ajar8VcjbCAeMjbth+mvLj3kZd2EXyfniXaV7BXdnOEJpW I2PlrcjSkpA/BJJ0h8FWQOwsGTauXI+Es3npw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fP9H0NfmnH39CvoMhVDgN4MIBYLW4dx4A1D7re6k5gk=; b=RPdw/Tda4b0XM/i6Yr80nCT+bdeeUnYsOT62wFEkYFtpdmPk/Jr8X9kaITn8vwEY2H oJVI9O60m0BfGVOu4GpbQ1QAZunWK06umdmoalLEoXpS6WgFd4irK8/FK2tA7QybGFSI DH/pnj3XXPckBeWzGv4/vA2hufWgFzIVV+O0CwjaI2TmLF8cgZeRp5QFCp7LiXobPMlm cklq/6nTVQwl+UQfZ9pBAYmUTHrnvJXJcwgZPdoUpc8jPvagagqwCTlYtgMuCpA1h+Nr dkb+k3q1Ic1SjwCvFV4blh/7Ce3EKI391/GbSGSd6s0n3eGs2YXMV5h1IlUTYMD2IeTR +3jQ== X-Gm-Message-State: AOAM5329JCCJwCmqWTnRb+cvQYrOiWbI3MQHkF8BOWaSTVCaj1izqk19 1606ESLMOdA6MaWswoHKgnyVMw== X-Google-Smtp-Source: ABdhPJxmn6oVWR/xWqYDbDhHu1EsrrkLU1zUpnfYSEU62rOSprJ1z/s50Ysi8ADShK+pmdMBVlLR5g== X-Received: by 2002:ac8:44cf:: with SMTP id b15mr16057309qto.325.1605891323285; Fri, 20 Nov 2020 08:55:23 -0800 (PST) Received: from localhost ([2620:15c:6:411:cad3:ffff:feb3:bd59]) by smtp.gmail.com with ESMTPSA id v16sm2394875qka.72.2020.11.20.08.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 08:55:22 -0800 (PST) Date: Fri, 20 Nov 2020 11:55:22 -0500 From: Joel Fernandes To: "Singh, Balbir" Cc: Nishanth Aravamudan , Julien Desfossez , Peter Zijlstra , Tim Chen , Vineeth Pillai , Aaron Lu , Aubrey Li , tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, keescook@chromium.org, kerrnel@google.com, Phil Auld , Valentin Schneider , Mel Gorman , Pawan Gupta , Paolo Bonzini , vineeth@bitbyteword.org, Chen Yu , Christian Brauner , Agata Gruza , Antonio Gomez Iglesias , graf@amazon.com, konrad.wilk@oracle.com, dfaggioli@suse.com, pjt@google.com, rostedt@goodmis.org, derkling@google.com, benbjiang@tencent.com, Alexandre Chartre , James.Bottomley@hansenpartnership.com, OWeisse@umich.edu, Dhaval Giani , Junaid Shahid , jsbarnes@google.com, chris.hyser@oracle.com, Ben Segall , Josh Don , Hao Luo , Tom Lendacky , Aubrey Li , "Paul E. McKenney" , Tim Chen Subject: Re: [PATCH -tip 01/32] sched: Wrap rq::lock access Message-ID: <20201120165522.GA1021337@google.com> References: <20201117232003.3580179-1-joel@joelfernandes.org> <20201117232003.3580179-2-joel@joelfernandes.org> <1489211d-594c-d244-0111-8bd8a27fb945@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1489211d-594c-d244-0111-8bd8a27fb945@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 20, 2020 at 10:31:39AM +1100, Singh, Balbir wrote: > On 18/11/20 10:19 am, Joel Fernandes (Google) wrote: > > From: Peter Zijlstra > > > > In preparation of playing games with rq->lock, abstract the thing > > using an accessor. > > > > Could you clarify games? I presume the intention is to redefine the scope > of the lock based on whether core sched is enabled or not? I presume patch > 4/32 has the details. Your line wrapping broke, I fixed it. That is in fact the game. By wrapping it, the nature of the locking is dynamic based on whether core sched is enabled or not (both statically and dynamically). thanks, - Joel > Balbir Singh