From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E78BEC56202 for ; Fri, 20 Nov 2020 20:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 826E022464 for ; Fri, 20 Nov 2020 20:09:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="cxREEUhu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730396AbgKTUJQ (ORCPT ); Fri, 20 Nov 2020 15:09:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729683AbgKTUJQ (ORCPT ); Fri, 20 Nov 2020 15:09:16 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 412CFC061A04 for ; Fri, 20 Nov 2020 12:09:16 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id w14so8922309pfd.7 for ; Fri, 20 Nov 2020 12:09:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TfymUBAMPnscgJxXttBDGIhTapd3XcXto9ob9Nf/8hk=; b=cxREEUhu03A0vRrbnkG/czu2MN+ftWNFq1cQEgKatoha9fssBw1sYNwNYvyCwYWs+N gVEw0g/WM3EavkUW4qVVXOpfC1vUDxHQruZiWIEoruLETt2GrO/3xSz0VSbAxijV9uAT oo+yPjsUuD8XKlUSSHnMpABuffY0yDdY5Gzvo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=TfymUBAMPnscgJxXttBDGIhTapd3XcXto9ob9Nf/8hk=; b=DbAC12DA4bBYMe87Js/A5GzOwEUjLbvACfPSzJHWmUt7m/tt3Zt1vk/HTk9Suwhc5p HuHxoOBQulMDCwTjp1g1eZrhkwTE9KDPmFRJNGlcA+XM7I084EfUzdD69Iyk0W2HQZfF 3SnftES/ZakztEU0u3d92RoJ80A5JZpE1qdamEWIkmQO0FQL6KV/ojOTaqVhWDqle5R/ ZmHlLgqIysI9Drkryw0NhQ0FGEPfW8w3wjxzQoZZd3E1WJ2/7Axko8SsndHGCodYa7E+ yHdU4bAMbY/Kznzd0o90LWQKXgOn8jntIvotKi+Z86mHrSUzTOrARJg9ZqXG1clD0z3p c5rw== X-Gm-Message-State: AOAM532bHHYy24jH/wBazHxBpb1S66RkLOThM4l6wy+K8FFAEfUpo/ff 9NFStYLpJ2D8E7Jua4b+38jFTQ== X-Google-Smtp-Source: ABdhPJwVOpRGlhivqD9EaIH5+QG3WF/E6o8+aD9UZFedVwwkNHBrM+ysmz0MnYPwE5pi6m4YFOmS5w== X-Received: by 2002:a17:90a:aa13:: with SMTP id k19mr12444785pjq.145.1605902955659; Fri, 20 Nov 2020 12:09:15 -0800 (PST) Received: from smtp.gmail.com ([100.99.132.239]) by smtp.gmail.com with ESMTPSA id r8sm4679626pfq.197.2020.11.20.12.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2020 12:09:15 -0800 (PST) From: Stephen Boyd To: Andy Gross , Bjorn Andersson Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Douglas Anderson Subject: [PATCH] arm64: dts: qcom: sc7180: Remove double pull-up on p-sensor-int-l Date: Fri, 20 Nov 2020 12:09:13 -0800 Message-Id: <20201120200913.618274-1-swboyd@chromium.org> X-Mailer: git-send-email 2.29.2.454.gaff20da3a2-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This interrupt has an external pull-up so we don't need to pull it up again. Drop the internal pull here. Note I don't think this really changes anything, just noticed while looking at this irq pin. Cc: Douglas Anderson Signed-off-by: Stephen Boyd --- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index d48a75afdafb..3eb1ff2483be 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -1331,7 +1331,8 @@ pinmux { pinconf { pins = "gpio24"; - bias-pull-up; + /* Has external pullup */ + bias-disable; }; }; base-commit: ead9f7d7ea9e20843e29e688b53859cea20044ee prerequisite-patch-id: 239dd75c9c3d2ef544f95466280f296fc217c096 -- https://chromeos.dev