linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Rui Salvaterra <rsalvaterra@gmail.com>
Cc: ngupta@vflare.org, sergey.senozhatsky.work@gmail.com,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] zram: break the strict dependency from lzo
Date: Fri, 20 Nov 2020 13:40:13 -0800	[thread overview]
Message-ID: <20201120214013.GD3377168@google.com> (raw)
In-Reply-To: <CALjTZvbK6_UqDQFhMxdEQAR-FbsZKrztkEFronvoFpLUWsi_gw@mail.gmail.com>

On Fri, Nov 20, 2020 at 09:10:13AM +0000, Rui Salvaterra wrote:
> Hi, Minchan,
> 
> On Thu, 19 Nov 2020 at 22:26, Minchan Kim <minchan@kernel.org> wrote:
> >
> > What's the purpose of ZRAM_AUTOSEL_ALGO?
> > If you and Sergey already discussed, sorry about the missing it.
> 
> The purpose of ZRAM_AUTOSEL_ALGO is to make sure at least one of the
> required compression algorithms is enabled, either as a module or
> built-in. I believe Sergey agreed with the reasoning behind it, but
> he'll let us know if I misunderstood. :)
> 
> > Below doesn't work for your goal?
> 
> Unfortunately, it doesn't. :( It breaks the dependency chain, allowing
> you to deselect all compression algorithms in the crypto menu, and

Hi Rui,

I don't understand it. Please see below.  ZRAM_COMP_LZO_DEF select
CRYPTO_LZO, not relying on it. If system supports other CRYPTO module
it will show on choice list. Otherwise, default lzo will be always
there and select CRYPTO_LZO.

Do I miss your point?

+
+choice
+       prompt "zram default compressor"
+       default ZRAM_COMP_LZO_DEF
+       depends on ZRAM || CRYPTO_LZ4
+       help
+         a
+
+config ZRAM_COMP_LZO_DEF
+       bool "lzo"
+       select CRYPTO_LZO
+       help
+         b
+
+config ZRAM_COMP_LZ4_DEF
+       bool "lz4"
+       depends on CRYPTO_LZ4
+       help
+         c
+endchoice
+
+config ZRAM_DEF_COMP
+       string
+       default "lzo" if ZRAM_COMP_LZO_DEF
+       default "lz4" if ZRAM_COMP_LZ4_DEF



  reply	other threads:[~2020-11-20 21:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15 10:15 [PATCH v5] zram: break the strict dependency from lzo Rui Salvaterra
2020-11-19 22:26 ` Minchan Kim
2020-11-20  9:10   ` Rui Salvaterra
2020-11-20 21:40     ` Minchan Kim [this message]
2020-11-21  0:44       ` Rui Salvaterra
2020-11-22  9:40         ` Rui Salvaterra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201120214013.GD3377168@google.com \
    --to=minchan@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=rsalvaterra@gmail.com \
    --cc=sergey.senozhatsky.work@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).