linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG
@ 2020-11-20 22:07 Karan Tilak Kumar
  2020-11-24  1:10 ` Arulprabhu Ponnusamy (arulponn)
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Karan Tilak Kumar @ 2020-11-20 22:07 UTC (permalink / raw)
  To: satishkh
  Cc: sebaddel, arulponn, jejb, martin.petersen, linux-scsi,
	linux-kernel, Karan Tilak Kumar

Replacing shost_printk with FNIC_FCS_DBG so that
these log messages are controlled by fnic_log_level
flag in fnic_fip_handler_timer.

Bumping up version number from 47 to 49 to
maintain same level as internal version.

Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
Signed-off-by: Satish Kharat <satishkh@cisco.com>
---
 drivers/scsi/fnic/fnic.h     | 2 +-
 drivers/scsi/fnic/fnic_fcs.c | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h
index 477513dc23b7..ed00b6061e0c 100644
--- a/drivers/scsi/fnic/fnic.h
+++ b/drivers/scsi/fnic/fnic.h
@@ -39,7 +39,7 @@
 
 #define DRV_NAME		"fnic"
 #define DRV_DESCRIPTION		"Cisco FCoE HBA Driver"
-#define DRV_VERSION		"1.6.0.47"
+#define DRV_VERSION		"1.6.0.49"
 #define PFX			DRV_NAME ": "
 #define DFX                     DRV_NAME "%d: "
 
diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
index e3384afb7cbd..3fc3a7271dc1 100644
--- a/drivers/scsi/fnic/fnic_fcs.c
+++ b/drivers/scsi/fnic/fnic_fcs.c
@@ -1349,7 +1349,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
 	}
 
 	vlan = list_first_entry(&fnic->vlans, struct fcoe_vlan, list);
-	shost_printk(KERN_DEBUG, fnic->lport->host,
+	FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
 		  "fip_timer: vlan %d state %d sol_count %d\n",
 		  vlan->vid, vlan->state, vlan->sol_count);
 	switch (vlan->state) {
@@ -1372,7 +1372,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
 			 * no response on this vlan, remove  from the list.
 			 * Try the next vlan
 			 */
-			shost_printk(KERN_INFO, fnic->lport->host,
+			FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
 				  "Dequeue this VLAN ID %d from list\n",
 				  vlan->vid);
 			list_del(&vlan->list);
@@ -1382,7 +1382,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
 				/* we exhausted all vlans, restart vlan disc */
 				spin_unlock_irqrestore(&fnic->vlans_lock,
 							flags);
-				shost_printk(KERN_INFO, fnic->lport->host,
+				FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
 					  "fip_timer: vlan list empty, "
 					  "trigger vlan disc\n");
 				fnic_event_enq(fnic, FNIC_EVT_START_VLAN_DISC);
-- 
2.29.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG
  2020-11-20 22:07 [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG Karan Tilak Kumar
@ 2020-11-24  1:10 ` Arulprabhu Ponnusamy (arulponn)
  2020-11-24  3:48 ` Martin K. Petersen
  2020-12-01  5:04 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Arulprabhu Ponnusamy (arulponn) @ 2020-11-24  1:10 UTC (permalink / raw)
  To: Karan Tilak Kumar (kartilak), Satish Kharat (satishkh)
  Cc: Sesidhar Baddela (sebaddel),
	jejb, martin.petersen, linux-scsi, linux-kernel

Changes look good.
Reviewed-by: Arulprabhu Ponnusamy <arulponn@cisco.com>

On 11/20/20, 2:08 PM, "Karan Tilak Kumar" <kartilak@cisco.com> wrote:

    Replacing shost_printk with FNIC_FCS_DBG so that
    these log messages are controlled by fnic_log_level
    flag in fnic_fip_handler_timer.

    Bumping up version number from 47 to 49 to
    maintain same level as internal version.

    Signed-off-by: Karan Tilak Kumar <kartilak@cisco.com>
    Signed-off-by: Satish Kharat <satishkh@cisco.com>
    ---
     drivers/scsi/fnic/fnic.h     | 2 +-
     drivers/scsi/fnic/fnic_fcs.c | 6 +++---
     2 files changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/scsi/fnic/fnic.h b/drivers/scsi/fnic/fnic.h
    index 477513dc23b7..ed00b6061e0c 100644
    --- a/drivers/scsi/fnic/fnic.h
    +++ b/drivers/scsi/fnic/fnic.h
    @@ -39,7 +39,7 @@

     #define DRV_NAME		"fnic"
     #define DRV_DESCRIPTION		"Cisco FCoE HBA Driver"
    -#define DRV_VERSION		"1.6.0.47"
    +#define DRV_VERSION		"1.6.0.49"
     #define PFX			DRV_NAME ": "
     #define DFX                     DRV_NAME "%d: "

    diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/fnic_fcs.c
    index e3384afb7cbd..3fc3a7271dc1 100644
    --- a/drivers/scsi/fnic/fnic_fcs.c
    +++ b/drivers/scsi/fnic/fnic_fcs.c
    @@ -1349,7 +1349,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     	}

     	vlan = list_first_entry(&fnic->vlans, struct fcoe_vlan, list);
    -	shost_printk(KERN_DEBUG, fnic->lport->host,
    +	FNIC_FCS_DBG(KERN_DEBUG, fnic->lport->host,
     		  "fip_timer: vlan %d state %d sol_count %d\n",
     		  vlan->vid, vlan->state, vlan->sol_count);
     	switch (vlan->state) {
    @@ -1372,7 +1372,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     			 * no response on this vlan, remove  from the list.
     			 * Try the next vlan
     			 */
    -			shost_printk(KERN_INFO, fnic->lport->host,
    +			FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
     				  "Dequeue this VLAN ID %d from list\n",
     				  vlan->vid);
     			list_del(&vlan->list);
    @@ -1382,7 +1382,7 @@ void fnic_handle_fip_timer(struct fnic *fnic)
     				/* we exhausted all vlans, restart vlan disc */
     				spin_unlock_irqrestore(&fnic->vlans_lock,
     							flags);
    -				shost_printk(KERN_INFO, fnic->lport->host,
    +				FNIC_FCS_DBG(KERN_INFO, fnic->lport->host,
     					  "fip_timer: vlan list empty, "
     					  "trigger vlan disc\n");
     				fnic_event_enq(fnic, FNIC_EVT_START_VLAN_DISC);
    -- 
    2.29.2



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG
  2020-11-20 22:07 [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG Karan Tilak Kumar
  2020-11-24  1:10 ` Arulprabhu Ponnusamy (arulponn)
@ 2020-11-24  3:48 ` Martin K. Petersen
  2020-12-01  5:04 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-11-24  3:48 UTC (permalink / raw)
  To: Karan Tilak Kumar
  Cc: satishkh, sebaddel, arulponn, jejb, martin.petersen, linux-scsi,
	linux-kernel


Karan,

> Replacing shost_printk with FNIC_FCS_DBG so that these log messages
> are controlled by fnic_log_level flag in fnic_fip_handler_timer.

Applied to 5.11/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG
  2020-11-20 22:07 [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG Karan Tilak Kumar
  2020-11-24  1:10 ` Arulprabhu Ponnusamy (arulponn)
  2020-11-24  3:48 ` Martin K. Petersen
@ 2020-12-01  5:04 ` Martin K. Petersen
  2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-12-01  5:04 UTC (permalink / raw)
  To: satishkh, Karan Tilak Kumar
  Cc: Martin K . Petersen, jejb, arulponn, sebaddel, linux-kernel, linux-scsi

On Fri, 20 Nov 2020 14:07:12 -0800, Karan Tilak Kumar wrote:

> Replacing shost_printk with FNIC_FCS_DBG so that
> these log messages are controlled by fnic_log_level
> flag in fnic_fip_handler_timer.
> 
> Bumping up version number from 47 to 49 to
> maintain same level as internal version.

Applied to 5.11/scsi-queue, thanks!

[1/1] scsi: fnic: Change shost_printk() to FNIC_FCS_DBG()
      https://git.kernel.org/mkp/scsi/c/90b3a938031f

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-12-01  5:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 22:07 [PATCH] scsi: fnic: Change shost_printk with FNIC_FCS_DBG Karan Tilak Kumar
2020-11-24  1:10 ` Arulprabhu Ponnusamy (arulponn)
2020-11-24  3:48 ` Martin K. Petersen
2020-12-01  5:04 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).