From: Masahiro Yamada <masahiroy@kernel.org>
To: Vineet Gupta <vgupta@synopsys.com>, linux-snps-arc@lists.infradead.org
Cc: Masahiro Yamada <masahiroy@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] ARC: build: add boot_targets to PHONY
Date: Sun, 22 Nov 2020 04:36:54 +0900 [thread overview]
Message-ID: <20201121193657.51441-4-masahiroy@kernel.org> (raw)
In-Reply-To: <20201121193657.51441-1-masahiroy@kernel.org>
The top-level boot_targets (uImage and uImage.*) should be phony
targets. They just let Kbuild descend into arch/arc/boot/ and create
files there.
If a file exists in the top directory with the same name, the boot
image will not be created.
You can confirm it by the following steps:
$ export CROSS_COMPILE=<your-arc-compiler-prefix>
$ make -s ARCH=arc defconfig all # vmlinux will be built
$ touch uImage.gz
$ make ARCH=arc uImage.gz
CALL scripts/atomic/check-atomics.sh
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
# arch/arc/boot/uImage.gz is not created
Specify the targets as PHONY to fix this.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
arch/arc/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arc/Makefile b/arch/arc/Makefile
index 61a41123ad4c..cf9da9aea12a 100644
--- a/arch/arc/Makefile
+++ b/arch/arc/Makefile
@@ -104,6 +104,7 @@ boot := arch/arc/boot
boot_targets := uImage uImage.bin uImage.gz uImage.lzma
+PHONY += $(boot_targets)
$(boot_targets): vmlinux
$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
--
2.25.1
next prev parent reply other threads:[~2020-11-21 19:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-21 19:36 [PATCH 0/6] ARC: build: fix various issues in arc boot Makefile Masahiro Yamada
2020-11-21 19:36 ` [PATCH 1/6] ARC: build: remove non-existing bootpImage from KBUILD_IMAGE Masahiro Yamada
2020-11-21 19:36 ` [PATCH 2/6] ARC: build: add uImage.lzma to the top-level target Masahiro Yamada
2020-11-21 19:36 ` Masahiro Yamada [this message]
2020-11-21 19:36 ` [PATCH 4/6] ARC: build: move symlink creation to arch/arc/Makefile to avoid race Masahiro Yamada
2020-11-21 19:36 ` [PATCH 5/6] ARC: build: remove unneeded extra-y Masahiro Yamada
2020-11-21 19:36 ` [PATCH 6/6] ARC: build: use $(READELF) instead of hard-coded readelf Masahiro Yamada
2020-11-25 4:40 ` [PATCH 0/6] ARC: build: fix various issues in arc boot Makefile Vineet Gupta
2020-12-01 12:27 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201121193657.51441-4-masahiroy@kernel.org \
--to=masahiroy@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).