linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Georgi Djakov <georgi.djakov@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Peter De Schrijver <pdeschrijver@nvidia.com>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Mikko Perttunen <cyndis@kapsi.fi>,
	Viresh Kumar <vireshk@kernel.org>,
	Peter Geis <pgwipeout@gmail.com>,
	Nicolas Chauvet <kwizart@gmail.com>,
	Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v10 08/19] drm/tegra: dc: Extend debug stats with total number of events
Date: Mon, 23 Nov 2020 03:27:12 +0300	[thread overview]
Message-ID: <20201123002723.28463-9-digetx@gmail.com> (raw)
In-Reply-To: <20201123002723.28463-1-digetx@gmail.com>

It's useful to know the total number of underflow events and currently
the debug stats are getting reset each time CRTC is being disabled. Let's
account the overall number of events that doesn't get a reset.

Tested-by: Peter Geis <pgwipeout@gmail.com>
Tested-by: Nicolas Chauvet <kwizart@gmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 drivers/gpu/drm/tegra/dc.c | 10 ++++++++++
 drivers/gpu/drm/tegra/dc.h |  5 +++++
 2 files changed, 15 insertions(+)

diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index 5c587cfd1bb2..b6676f1fe358 100644
--- a/drivers/gpu/drm/tegra/dc.c
+++ b/drivers/gpu/drm/tegra/dc.c
@@ -1539,6 +1539,11 @@ static int tegra_dc_show_stats(struct seq_file *s, void *data)
 	seq_printf(s, "underflow: %lu\n", dc->stats.underflow);
 	seq_printf(s, "overflow: %lu\n", dc->stats.overflow);
 
+	seq_printf(s, "frames total: %lu\n", dc->stats.frames_total);
+	seq_printf(s, "vblank total: %lu\n", dc->stats.vblank_total);
+	seq_printf(s, "underflow total: %lu\n", dc->stats.underflow_total);
+	seq_printf(s, "overflow total: %lu\n", dc->stats.overflow_total);
+
 	return 0;
 }
 
@@ -2310,6 +2315,7 @@ static irqreturn_t tegra_dc_irq(int irq, void *data)
 		/*
 		dev_dbg(dc->dev, "%s(): frame end\n", __func__);
 		*/
+		dc->stats.frames_total++;
 		dc->stats.frames++;
 	}
 
@@ -2318,6 +2324,7 @@ static irqreturn_t tegra_dc_irq(int irq, void *data)
 		dev_dbg(dc->dev, "%s(): vertical blank\n", __func__);
 		*/
 		drm_crtc_handle_vblank(&dc->base);
+		dc->stats.vblank_total++;
 		dc->stats.vblank++;
 	}
 
@@ -2325,6 +2332,7 @@ static irqreturn_t tegra_dc_irq(int irq, void *data)
 		/*
 		dev_dbg(dc->dev, "%s(): underflow\n", __func__);
 		*/
+		dc->stats.underflow_total++;
 		dc->stats.underflow++;
 	}
 
@@ -2332,11 +2340,13 @@ static irqreturn_t tegra_dc_irq(int irq, void *data)
 		/*
 		dev_dbg(dc->dev, "%s(): overflow\n", __func__);
 		*/
+		dc->stats.overflow_total++;
 		dc->stats.overflow++;
 	}
 
 	if (status & HEAD_UF_INT) {
 		dev_dbg_ratelimited(dc->dev, "%s(): head underflow\n", __func__);
+		dc->stats.underflow_total++;
 		dc->stats.underflow++;
 	}
 
diff --git a/drivers/gpu/drm/tegra/dc.h b/drivers/gpu/drm/tegra/dc.h
index 0d7bdf66a1ec..ba4ed35139fb 100644
--- a/drivers/gpu/drm/tegra/dc.h
+++ b/drivers/gpu/drm/tegra/dc.h
@@ -48,6 +48,11 @@ struct tegra_dc_stats {
 	unsigned long vblank;
 	unsigned long underflow;
 	unsigned long overflow;
+
+	unsigned long frames_total;
+	unsigned long vblank_total;
+	unsigned long underflow_total;
+	unsigned long overflow_total;
 };
 
 struct tegra_windowgroup_soc {
-- 
2.29.2


  parent reply	other threads:[~2020-11-23  0:32 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20201123003254epcas1p1763e1ce693d7cb8e2f20d521e701ad5f@epcas1p1.samsung.com>
2020-11-23  0:27 ` [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 01/19] dt-bindings: memory: tegra20: emc: Document opp-supported-hw property Dmitry Osipenko
2020-11-30  9:48     ` Georgi Djakov
2020-11-30 18:23       ` Krzysztof Kozlowski
2020-11-30 20:03         ` Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 02/19] memory: tegra20: Support hardware versioning and clean up OPP table initialization Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 03/19] memory: tegra30: Support interconnect framework Dmitry Osipenko
2020-11-23  6:32     ` Georgi Djakov
2020-11-23 12:14       ` Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 04/19] memory: tegra124-emc: Make driver modular Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 05/19] memory: tegra124-emc: Continue probing if timings are missing in device-tree Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 06/19] memory: tegra124: Support interconnect framework Dmitry Osipenko
2020-11-23  6:33     ` Georgi Djakov
2020-11-23  0:27   ` [PATCH v10 07/19] drm/tegra: dc: Support memory bandwidth management Dmitry Osipenko
2020-11-23  0:27   ` Dmitry Osipenko [this message]
2020-11-23  0:27   ` [PATCH v10 09/19] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree Dmitry Osipenko
2020-11-23  7:02     ` Chanwoo Choi
2020-11-23 12:14       ` Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 10/19] PM / devfreq: tegra30: Separate configurations per-SoC generation Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 11/19] PM / devfreq: tegra20: Deprecate in a favor of emc-stat based driver Dmitry Osipenko
2020-11-23  7:02     ` Chanwoo Choi
2020-11-23  0:27   ` [PATCH v10 12/19] ARM: tegra: Correct EMC registers size in Tegra20 device-tree Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 13/19] ARM: tegra: Add interconnect properties to " Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 14/19] ARM: tegra: Add interconnect properties to Tegra30 device-tree Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 15/19] ARM: tegra: Add interconnect properties to Tegra124 device-tree Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 16/19] ARM: tegra: Add nvidia,memory-controller phandle to Tegra20 EMC device-tree Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees Dmitry Osipenko
2020-11-30 21:17     ` Jon Hunter
2020-11-30 22:57       ` Dmitry Osipenko
2020-12-01 20:42         ` Jon Hunter
2020-12-04 15:54         ` Thierry Reding
2020-12-05 13:52           ` Krzysztof Kozlowski
2020-11-23  0:27   ` [PATCH v10 18/19] ARM: tegra: Add EMC OPP and ICC properties to Tegra30 EMC and ACTMON device-tree nodes Dmitry Osipenko
2020-11-23  0:27   ` [PATCH v10 19/19] ARM: tegra: Add EMC OPP and ICC properties to Tegra124 " Dmitry Osipenko
2020-11-23  6:17   ` [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs Viresh Kumar
2020-11-23 12:13     ` Dmitry Osipenko
2020-11-30  8:44   ` Chanwoo Choi
2020-11-30  8:36     ` Krzysztof Kozlowski
2020-11-30  8:59       ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201123002723.28463-9-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=cyndis@kapsi.fi \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=georgi.djakov@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=kwizart@gmail.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgwipeout@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).