From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB4BC6379D for ; Mon, 23 Nov 2020 03:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 555D02145D for ; Mon, 23 Nov 2020 03:47:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QAj3nMDX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727688AbgKWDr3 (ORCPT ); Sun, 22 Nov 2020 22:47:29 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:39445 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbgKWDr2 (ORCPT ); Sun, 22 Nov 2020 22:47:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606103247; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RBxcPYH+vdk8Hh+y1ztx/6aT2W6/WgcV8+UQyj1Byj0=; b=QAj3nMDXlAjXcSw7re791Ltk9IIMyfeRlPGkEosl+G3riPLTx8E5Radhx1huhxuSb3CGou o14fjsZZuOgEXFn0e/D/nu3GUJ+WVTDjgiuhe6mnlTGFcT6I5s9TsLaFuwA7aFiCaLmT7T hwp8679PVDXQWdCIUm0GYIWQBUMeQvE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-494-QHdtGe_NPWCUZAllIfaYtg-1; Sun, 22 Nov 2020 22:47:25 -0500 X-MC-Unique: QHdtGe_NPWCUZAllIfaYtg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F1E61809DE3; Mon, 23 Nov 2020 03:47:20 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-80.pek2.redhat.com [10.72.12.80]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4FE655C1C4; Mon, 23 Nov 2020 03:47:09 +0000 (UTC) Date: Mon, 23 Nov 2020 11:47:05 +0800 From: Dave Young To: Guilherme Piccoli Cc: Kairui Song , Saeed Mirzamohammadi , Geert Uytterhoeven , linux-doc@vger.kernel.org, Catalin Marinas , Bjorn Andersson , "H. Peter Anvin" , Will Deacon , Anson Huang , Jonathan Corbet , the arch/x86 maintainers , Michael Walle , Krzysztof Kozlowski , Ingo Molnar , Vivek Goyal , John Donnelly , Arnd Bergmann , Borislav Petkov , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Baoquan He , "Martin K. Petersen" , Randy Dunlap , kexec mailing list , Linux Kernel Mailing List , "# v4 . 16+" , Li Yang , Miguel Ojeda , Vinod Koul , Diego Elio =?iso-8859-1?Q?Petten=F2?= , Olof Johansson , Shawn Guo Subject: Re: [PATCH 1/1] kernel/crash_core.c - Add crashkernel=auto for x86 and ARM Message-ID: <20201123034705.GA5908@dhcp-128-65.nay.redhat.com> References: <20201118232431.21832-1-saeed.mirzamohammadi@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Guilherme, On 11/22/20 at 12:32pm, Guilherme Piccoli wrote: > Hi Dave and Kairui, thanks for your responses! OK, if that makes sense > to you I'm fine with it. I'd just recommend to test recent kernels in > multiple distros with the minimum "range" to see if 64M is enough for > crashkernel, maybe we'd need to bump that. Giving the different kernel configs and the different userspace initramfs setup it is hard to get an uniform value for all distributions, but we can have an interface/kconfig-option for them to provide a value like this patch is doing. And it could be improved like Kairui said about some known kernel added extra values later, probably some more improvements if doable. Thanks Dave